From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Alexander Gramiak <agrambot@gmail.com>
Subject: Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames
Date: Sun, 28 Apr 2019 21:50:21 -0400 [thread overview]
Message-ID: <jwvmuk9k2d2.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20190427033621.4934B206A2@vcs0.savannah.gnu.org> (Alexander Gramiak's message of "Fri, 26 Apr 2019 23:36:20 -0400 (EDT)")
> - if (FRAME_RIF (f)->clear_under_internal_border)
> + if (FRAME_WINDOW_P (f)
> + && FRAME_RIF (f)->clear_under_internal_border)
Wouldn't testing FRAME_RIF(f) instead of FRAME_WINDOW_P(f) make
more sense? At least, it would not rely on the fact that FRAME_RIF(f)
is supposedly non-NULL when FRAME_WINDOW_P(f) is true.
It'd make the code more "obviously safe".
Stefan
next parent reply other threads:[~2019-04-29 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190427033619.18077.55804@vcs0.savannah.gnu.org>
[not found] ` <20190427033621.4934B206A2@vcs0.savannah.gnu.org>
2019-04-29 1:50 ` Stefan Monnier [this message]
2019-04-29 3:28 ` [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames Alex Gramiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmuk9k2d2.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).