From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Prickliness of the "invalid byte code" stuff Date: Sun, 16 Jun 2019 09:27:25 -0400 Message-ID: References: <87tvcq9b0w.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1075"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 15:28:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcVCV-00005M-6r for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 15:28:03 +0200 Original-Received: from localhost ([::1]:39828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcVCT-00075o-Ea for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 09:28:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53217) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcVC2-00075i-4t for emacs-devel@gnu.org; Sun, 16 Jun 2019 09:27:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcVC1-0002kJ-6g for emacs-devel@gnu.org; Sun, 16 Jun 2019 09:27:34 -0400 Original-Received: from [195.159.176.226] (port=46424 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcVC0-0002cI-VE for emacs-devel@gnu.org; Sun, 16 Jun 2019 09:27:33 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hcVBy-0017ox-HJ for emacs-devel@gnu.org; Sun, 16 Jun 2019 15:27:30 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:OSukYyxKDxAnr7WBJLsFMqAFLy4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237726 Archived-At: > I just did a very simple test: I deleted all the .elc files and then > said `C-x v g' on a file and got the familiar "invalid byte code" > message. At least in this instance it would be more helpful to say that > the .elc file no longer exists... or perhaps not backtrace at all, but > just load .el file? IIRC while some details can be improved, it's pretty hard to make it work really well in all cases without making non-trivial changes. But there's an easy fix for the specific problem you mention (see attached). Maybe this fix should be applied to all the relevant files. [ The lack of smileys is because I'm suggesting this quite seriously: AFAIK this is a micro-optimization which doesn't make much sense nowadays anyway. Has anyone bothered to actually measure the speed up it can offer? ] Stefan diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 24e79acfa5..7e11dd2e4a 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -3397,7 +3397,6 @@ cl-struct-slot-value (run-hooks 'cl-macs-load-hook) ;; Local variables: -;; byte-compile-dynamic: t ;; generated-autoload-file: "cl-loaddefs.el" ;; End: