From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t
Date: Mon, 27 Jul 2020 10:10:46 -0400 [thread overview]
Message-ID: <jwvmu3lgihm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tuxtbpsp.fsf@iris.silentflame.com> (Sean Whitton's message of "Sun, 26 Jul 2020 20:27:34 -0700")
>>> Bind switch-to-buffer-obey-display-actions to t
>> This sounds wrong. Why not change the rest of the code to use
>> `pop-to-buffer-same-window` instead?
> AIUI Dmitry made this change purely so that project-switch-to-buffer
> would work with project-other-*-command. So are you suggesting that
> project-switch-to-buffer use pop-to-buffer-same-window?
Yes.
> I think that would not be ideal, because for users with
> switch-to-buffer-obey-display-actions set to nil globally, it is good
> that switch-to-buffer unconditionally uses the selected window, and it
`pop-to-buffer-same-window` uses the selected window "unconditionally"
in 99.9763% (seat of pants estimate) of the cases. And the here patch
shows that we don't want this code to use the selected window
unconditionally in 100% of the cases, so `pop-to-buffer-same-window`
seems exactly like what we need.
Stefan
prev parent reply other threads:[~2020-07-27 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200726235725.458.96146@vcs0.savannah.gnu.org>
[not found] ` <20200726235727.D751320A1C@vcs0.savannah.gnu.org>
2020-07-27 2:07 ` master 7551aff 4/4: Bind switch-to-buffer-obey-display-actions to t Stefan Monnier
2020-07-27 3:27 ` Sean Whitton
2020-07-27 14:10 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmu3lgihm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).