From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Perl and Emacs: Developing tests for progmodes Date: Thu, 03 Sep 2020 11:52:02 -0400 Message-ID: References: <935d77f8-72c4-16fd-f9d6-39ba965e99e8@posteo.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , emacs-devel@gnu.org To: Harald =?windows-1252?Q?J=F6rg?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 03 17:52:55 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDrXj-0004Li-AO for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Sep 2020 17:52:55 +0200 Original-Received: from localhost ([::1]:40934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDrXi-0003L1-DP for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Sep 2020 11:52:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDrX1-0002lw-Pq for emacs-devel@gnu.org; Thu, 03 Sep 2020 11:52:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDrWy-0004tX-8Q for emacs-devel@gnu.org; Thu, 03 Sep 2020 11:52:11 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 09A8B100227; Thu, 3 Sep 2020 11:52:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DA356100234; Thu, 3 Sep 2020 11:52:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599148323; bh=MOMTec2RJjiHqqBF7RjLozsUHKoCAO/3lgGP+IrKmT4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=b5d8E65xcIop7juSe21xui2gEXkkHUUSJMMGoezZPCK9BDMjr5GfOpIe+MaNcVe/E LOzh4CzjAEr8GFJ91yumO0ilXd1OjUZXgyYZQDAzMG2STkA+8KpnMiRTycFGQxILM2 bvYo8jMEUeIemmIbgl12QPhUTJlSb8So6yuiEQqNGlnSrs/9MBOKc1hPi1KPnGG+Vu +Vi4wpRDny1QEJ2xplPypSwgkTcahEQNBcT7H/LKRRkwaQAnm9302OEd0dibOix07t 3dwqt/fWYCBxQjy1sy9LmfgDsJW5HmcPNETcTQV05xDJkX9/8AiwuuKxGeOrkKrPua TqAFZFQ81skIg== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 86712120439; Thu, 3 Sep 2020 11:52:03 -0400 (EDT) In-Reply-To: <935d77f8-72c4-16fd-f9d6-39ba965e99e8@posteo.de> ("Harald =?windows-1252?Q?J=F6rg=22's?= message of "Thu, 3 Sep 2020 15:42:47 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 11:52:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254498 Archived-At: > However, there are bugs in cperl-mode which perl-mode doesn't have, > mostly because perl-mode doesn't offer the functions which fail in the > first place. So, tests for these bugs need to (require 'cperl-mode), > and they make no sense when testing perl-mode. I expect most of the > upcoming tests to fall into that category. > > To solve this, we could: > > - Split the tests into two and manually copy over tests where this > makes sense or: > > - Split the tests into a "common" set plus two sets for the specific > modes (how would the files be named in that case?) or: > > - Keep all tests in one file and tag the individual tests. I think for now we can tag the tests individually with (ert-deftest (...) (skip-unless (eq cperl-test-mode #'cperl-mode)) ...) We can change later if that becomes inconvenient (e.g. almost all the tests only apply to cperl-mode). Stefan