From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 6924320: Take care of a FIXME in cus-edit-tests.el Date: Fri, 20 Nov 2020 16:57:57 -0500 Message-ID: References: <20201120213804.8196.42565@vcs0.savannah.gnu.org> <20201120213806.0C179209DE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1521"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 20 22:58:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgEQP-0000Gp-8A for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Nov 2020 22:58:37 +0100 Original-Received: from localhost ([::1]:59030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgEQO-0003Wc-6v for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Nov 2020 16:58:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgEPq-00035H-PI for emacs-devel@gnu.org; Fri, 20 Nov 2020 16:58:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37128) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgEPo-0003mB-Qt for emacs-devel@gnu.org; Fri, 20 Nov 2020 16:58:02 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ACCF344159F; Fri, 20 Nov 2020 16:57:59 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 50006441592; Fri, 20 Nov 2020 16:57:58 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1605909478; bh=5uflgnD1XKVumUFcfqu7rLZM6Ci6LSYLeWEkcxgnPmw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SeHsVIyDT+/TPfX4Ilss6TXzJFosTnvm+XgoFPE7KGX4roWKmorcqX44YiAhXoDj0 EBV7/2/jx2XZm1YiieEm8zjY8QHfUa0ft9V/3KcPK0DlMIhw42fHGuXDstAUX/gfUw iH5929RWkfisUSC6JFmr73MXM87ZUnaah3AmXQj49oFC4TY01EX0DNoTLRVP4v3wy/ +mAXyr4HdE+amqKgysIaCX5/af9sXGF4PeGv+AdRX4QezoiKJTYQr7gJHS3Nu4Qhfn v5pOyqlYHazWR0Hr0pjvfRF1T9ld+og2qR7r2aY8PbJQiirajXDtwALz352IQqKbg2 ENDQSedIrriUA== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1EB87120284; Fri, 20 Nov 2020 16:57:58 -0500 (EST) In-Reply-To: <20201120213806.0C179209DE@vcs0.savannah.gnu.org> (Mauro Aranda's message of "Fri, 20 Nov 2020 16:38:05 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259506 Archived-At: > - (customize-saved) > - (should (search-forward cus-edit-tests--obsolete-option-tag nil t)))) > + (unwind-protect > + (progn > + (put 'cus-edit-tests--obsolete-option-tag 'saved-value '(t)) > + (customize-saved) > + (should (search-forward cus-edit-tests--obsolete-option-tag nil t))) > + (put 'cus-edit-tests--obsolete-option-tag 'saved-value nil)))) These are (fairly rare) good use-cases for `cl-letf`: (cl-letf (((get 'cus-edit-tests--obsolete-option-tag 'saved-value) '(t))) (customize-saved) (should (search-forward cus-edit-tests--obsolete-option-tag nil t))) -- Stefan