From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 6924320: Take care of a FIXME in cus-edit-tests.el
Date: Fri, 20 Nov 2020 16:57:57 -0500 [thread overview]
Message-ID: <jwvmtzbzoag.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20201120213806.0C179209DE@vcs0.savannah.gnu.org> (Mauro Aranda's message of "Fri, 20 Nov 2020 16:38:05 -0500 (EST)")
> - (customize-saved)
> - (should (search-forward cus-edit-tests--obsolete-option-tag nil t))))
> + (unwind-protect
> + (progn
> + (put 'cus-edit-tests--obsolete-option-tag 'saved-value '(t))
> + (customize-saved)
> + (should (search-forward cus-edit-tests--obsolete-option-tag nil t)))
> + (put 'cus-edit-tests--obsolete-option-tag 'saved-value nil))))
These are (fairly rare) good use-cases for `cl-letf`:
(cl-letf (((get 'cus-edit-tests--obsolete-option-tag 'saved-value) '(t)))
(customize-saved)
(should (search-forward cus-edit-tests--obsolete-option-tag nil t)))
-- Stefan
next parent reply other threads:[~2020-11-20 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201120213804.8196.42565@vcs0.savannah.gnu.org>
[not found] ` <20201120213806.0C179209DE@vcs0.savannah.gnu.org>
2020-11-20 21:57 ` Stefan Monnier [this message]
2020-11-20 22:16 ` master 6924320: Take care of a FIXME in cus-edit-tests.el Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmtzbzoag.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).