From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Additional cleanup around xterm-mouse Date: Sun, 27 Dec 2020 12:10:47 -0500 Message-ID: References: <90ff03cd289ec32998b44bb486b32d5e@finder.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Jared Finder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 27 18:12:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktZaj-0002G9-SY for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Dec 2020 18:12:25 +0100 Original-Received: from localhost ([::1]:40676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktZai-0005w2-Ug for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Dec 2020 12:12:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktZZO-0005Sh-Qb for emacs-devel@gnu.org; Sun, 27 Dec 2020 12:11:03 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktZZE-0004WG-NG; Sun, 27 Dec 2020 12:10:59 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E850D4405E5; Sun, 27 Dec 2020 12:10:50 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BA2E94401B0; Sun, 27 Dec 2020 12:10:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1609089049; bh=Tq91S8w/8u4ujlZFa780coao6JQ+6DC/jHBVtRoq4XQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lOS9mOoP/uNl8LUGb2h5gAalJOhRv51FJA5Ju0bOmnymFN2jnpJDxpFsVr/XaS5EZ T8w7MVTlGkEeO2tEcpWKaliUb6tpLyvczqFWHoXyT6xLeiiRFJO19DDAM1ALshomFG 5fdjbjv3aRz7RyZ5/M1bZKlqFpVBChABEjkoc9BdLi8FKhhF0zLImokKTnOKhOQ68D xuwk7fzSjuH1jc9mgtynxNRkIKxZ9nr9RhSkUZJU4BAz6hOfiHgCCLVmAbYWtuK1se V90zmXsM0J+LgMeZL0vlRMR2mj6txDjE6GvSqMdQ97NcE1eghzq9nF2Yb8Qyld4oyK GLlOR4MXgnLkQ== Original-Received: from alfajor (unknown [104.247.243.191]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7F5DA1204AE; Sun, 27 Dec 2020 12:10:49 -0500 (EST) In-Reply-To: <90ff03cd289ec32998b44bb486b32d5e@finder.org> (Jared Finder's message of "Sun, 27 Dec 2020 08:30:44 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261907 Archived-At: >>> -@defun read-key &optional prompt >>> +@defun read-key &optional prompt all-fallbacks-disabled >> FWIW, I would call it "fallbacks-disabled". > I want to distinguish it from the very similar intentioned but somewhat > differing behaving parameter to read-key-sequence. I wouldn't worry 'bout that. It also occurs to me that it could use a more active form, like `disable-fallbacks`. > This needs to also avoid binding ESC as well, e.g. adding (define-key map > [?\e] nil). Cursory testing locally with that as well shows this working > out well. Oh, that brings back memories of when I wrote `read-key`. This is quite delicate indeed. We're in dire need of tests for those things. > This assumes that ESC is the only prefix key in input-decode-map. > Is that an okay assumption to make? I think so. Stefan