From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 496bed5: Change command-completion-using-modes-p to defun Date: Sat, 20 Feb 2021 10:00:28 -0500 Message-ID: References: <20210220144350.4736.64583@vcs0.savannah.gnu.org> <20210220144351.6424B20B7C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 20 16:01:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDTlb-0008uT-UF for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 16:01:55 +0100 Original-Received: from localhost ([::1]:49662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDTla-0003mn-Qk for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 10:01:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDTkH-0002lm-R1 for emacs-devel@gnu.org; Sat, 20 Feb 2021 10:00:33 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDTkG-0000WQ-5b for emacs-devel@gnu.org; Sat, 20 Feb 2021 10:00:33 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 769571000DA; Sat, 20 Feb 2021 10:00:31 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EA7D7100240; Sat, 20 Feb 2021 10:00:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613833229; bh=iILiwJCKK+Dm1hsipOhdjXwJ0wm7mRCyysklhRiV1Gg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=b0V6hUJ60+t7IysW9iS/wqlCXO6fspwC1QtLJyqkx84iAdMkoMd3S5fea+qdEz/z2 ej9z47g1ropRqrYkynXYkaRn2X1D++/uRm3uACR8qEvmbQ5k3uz9S7LzEkL4/giSnz RLY1cDuRra1oLV7YITVpbXER5maGu8r+fOwp6xBq8MHsNaeDCNoS3HKBALmQGEnc4d iXGVkqAjI8DnnmbH+VZRc4f2oDMlJRTLBPWoO+5t0qTaRWGKGTfvUicuEsW4aWpaK8 /TMdc1YA2oNeyrBEB1s70KMcxKze+5eEqNbRNornLdz+f50hsm/wKiIkuuMyTsmFZk gHalCv3NYyvRA== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7DD0F120327; Sat, 20 Feb 2021 10:00:29 -0500 (EST) In-Reply-To: <20210220144351.6424B20B7C@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 20 Feb 2021 09:43:50 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265327 Archived-At: > -(define-inline command-completion-using-modes-p (symbol buffer) > +(defun command-completion-using-modes-p (symbol buffer) `define-inline` can be used to define inlinable functions, but it's not like `defsubst`: the body needs to be changed to look a bit more like what a macro would look like. Stefan