From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 31544bc: =?utf-8?Q?Don=E2=80=99t?= convert pointer to bool Date: Sat, 20 Mar 2021 10:05:55 -0400 Message-ID: References: <20210320004804.9441.45535@vcs0.savannah.gnu.org> <20210320004805.B7BBF2101A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19938"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 20 15:06:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNcFg-00055l-3K for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 15:06:52 +0100 Original-Received: from localhost ([::1]:37668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNcFf-0007vB-49 for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 10:06:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNcEq-0007V4-VU for emacs-devel@gnu.org; Sat, 20 Mar 2021 10:06:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNcEo-0002h9-VY for emacs-devel@gnu.org; Sat, 20 Mar 2021 10:06:00 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 210404408EE; Sat, 20 Mar 2021 10:05:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E9CBC4409D5; Sat, 20 Mar 2021 10:05:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616249156; bh=lNMoxBXLb2nxHKmNJ/QpLCLsTVoMsolxxuM6QxWv/r4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=H6ZS2zspwG3s2DIh47fz35N+2LvoO1Cn7w/Rl8InKfSQ65OtTS4Cwgg0Sx5pdHg4H TmxeV4ZN/rPjpqssayo1lI5AAXHj4vce4N2L+45GDvxGEx3Y0TuYN7MElOy49eLy4Z wKlEgLVVViFI9wMBYhr0fMGV/xJYlsA05gmQBvBVCYZHSu4FUQGTZk+ujDKRVFDUm+ 5hrTjgE6EGvlWALaJwTbZLl/XZN/3eimXZtbv4kpksfenXKDkfWBw9Iajm+zAbjneN H7e6sk/9axt21Lg+5fjWjHks4amnqCUJK/IIxGcvTaOnP269H0atIv+LYX1sWaRN9k NkdQB2LPzc/Ig== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 471B512021E; Sat, 20 Mar 2021 10:05:56 -0400 (EDT) In-Reply-To: <20210320004805.B7BBF2101A@vcs0.savannah.gnu.org> (Paul Eggert's message of "Fri, 19 Mar 2021 20:48:05 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266652 Archived-At: > Without this patch, Oracle Studio 12.6 complains about converting > pointer to bool. Is it right to complain or is that a bug in that tool? To my naive intuition, it looks wrong since conversion to bool is standard practice when doing `if (ptr) ...`. Stefan