From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Sun, 09 May 2021 14:01:50 -0400 Message-ID: References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <871rak2qno.fsf@gnus.org> <87pmy3uec8.fsf@gnus.org> <87tuncnse1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36461"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Karl Fogel , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 20:02:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfnlL-0009NW-Rr for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 20:02:44 +0200 Original-Received: from localhost ([::1]:47208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfnlK-0000Ob-Ts for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 14:02:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfnkc-00088S-Mt for emacs-devel@gnu.org; Sun, 09 May 2021 14:01:58 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfnkY-0006NV-QB for emacs-devel@gnu.org; Sun, 09 May 2021 14:01:57 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5C3E4808D4; Sun, 9 May 2021 14:01:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 196C18079B; Sun, 9 May 2021 14:01:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620583312; bh=hNMeI1YqVLCfuEq9r0AH9yzGqaZFtB7bbapzahbFYq0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=m/GiRxYBAfc/Yg0JVvGLmk34JjkFTFzBpUvf/tzRjHgG6FYNKUs2mYnXgct1aA3Iz L14EwteUfqIr5bQ+Gaw6gnLf2B5jDJyau3s52gRSLP93FlhIdEDc9cbYHrFA9xDnhQ cGRuz0nKh4NuUXZrjKgXAY/WSECDrwyX6+/hIMqO/Yzag4Nkhx+eJc1sakZSgoNXul pI4F/8NrafpMUWmn0R40x1GMJDKCjB2Uewc9JwaWyAFaL9K51r8uQArND1QkzIYLNy 8cj3IcYTtFlB0B3OFdb1Y6Z2pPlChYSdRSdXRwCgK1yhTZjlOg+QQFa32DBZTItf9p XjOQYAASs7cWg== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C61C612026E; Sun, 9 May 2021 14:01:51 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Sun, 9 May 2021 10:04:57 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269085 Archived-At: Stefan Kangas [2021-05-09 10:04:57] wrote: > Lars Ingebrigtsen writes: >> Sure, we could extend the `disabled' machinery easily enough. For >> instance, we could allow arbitrary functions, and then recommend that >> people say >> >> (put 'some-command 'disabled 'y-or-n-p) >> >> in their Emacs files to confirm before calling? Should be pretty >> trivial to implement. > > I'm wondering what the use-case is here. If there are any commands > where something like this would be useful, shouldn't we just treat that > as a bug and add a prompt? > > Or do you have any commands in mind where users might want to add a > prompt, but we would not? I think what this is getting at is to have a standardized way to have and control such prompts. Whether it's done via symbol-properties, inline code, advice-add, or younameit is "an implementation detail". Stefan