From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philipp Stephani <phst@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 42950e9: Fix a few Edebug specifications where code is wrapped in lambdas.
Date: Sat, 22 May 2021 13:31:08 -0400 [thread overview]
Message-ID: <jwvmtsm65pd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210517081337.02F1021128@vcs0.savannah.gnu.org> (Philipp Stephani's message of "Mon, 17 May 2021 04:13:36 -0400 (EDT)")
> Fix a few Edebug specifications where code is wrapped in lambdas.
>
> As the Info node `(elisp) Specification List' explains, it is not
> correct to use `body' or t for a piece of code that the macro wraps in
> a `lambda' form. These should use `def-body' instead.
There is a slight misunderstanding here: if the end behavior is the same
as what could happen without a lambda, then there's no need to use
`def-body`.
The use `def-body` is only needed if it's possible to enter this code
from non-instrumented code (e.g. when the lambda is passed to
`run-with-timer`).
In the case of `displaying-byte-compile-warnings`, for example, there is
no need for `def-body`.
Stefan
next parent reply other threads:[~2021-05-22 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210517081335.25338.24020@vcs0.savannah.gnu.org>
[not found] ` <20210517081337.02F1021128@vcs0.savannah.gnu.org>
2021-05-22 17:31 ` Stefan Monnier [this message]
2021-05-22 21:24 ` master 42950e9: Fix a few Edebug specifications where code is wrapped in lambdas Emanuel Berg via Emacs development discussions.
2021-05-23 10:22 ` Philipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmtsm65pd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).