From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Sat, 30 Apr 2022 09:44:53 -0400 Message-ID: References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> <87o80i3frf.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37317"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Juri Linkov , emacs-devel@gnu.org To: James N. V. Cash Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 30 16:10:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nknnw-0009YY-Cn for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 16:10:36 +0200 Original-Received: from localhost ([::1]:52100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nknnv-0004tl-2Z for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Apr 2022 10:10:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nknPB-0003IZ-RH for emacs-devel@gnu.org; Sat, 30 Apr 2022 09:45:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nknP9-0008E3-5X for emacs-devel@gnu.org; Sat, 30 Apr 2022 09:45:00 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8EC1E10027D; Sat, 30 Apr 2022 09:44:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C0D31100121; Sat, 30 Apr 2022 09:44:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651326295; bh=We9mih/ng+pkdPzcMf4KoKG3qalmZ5B5JIrKlkL3yZ4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oUh0C+caGk1qSGQM119anGCJh/PGawOEwYhI88cA/m3rbTcN52nPMv+EY6JNaKDRg XJAWW3eDwM62MI1W7GZPTM2SFSvcPtMLtsmDlk2COnYAg20dYrb/PpCcaH+NPFQjPg BxsWv6scWMDv8b1fvaBlY+YuWTvfXru6fqFweOsMtQh2ZFwzCeFKmgkJ2z33oSpcQy A9ZEz1paKAqucTJ1JdGlQu6SlSsfDxRqrPACqeEjXBfwFGxYGoKnc18LOQj3Ic7QcG wde7aAXhBc3yCUhKfKvTiqRHR9s2c25veUJL6HQHKNErDZH5/WcwpSxqZo45fk9/0O kTJT1hWEVKUiA== Original-Received: from alfajor (modemcable034.207-20-96.mc.videotron.ca [96.20.207.34]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 818A3120600; Sat, 30 Apr 2022 09:44:55 -0400 (EDT) In-Reply-To: <87o80i3frf.fsf@occasionallycogent.com> (James N. V. Cash's message of "Sat, 30 Apr 2022 08:41:24 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289057 Archived-At: James N. V. Cash [2022-04-30 08:41:24] wrote: > Stefan Monnier writes: > >>>> + (let ((beg (if (number-or-marker-p beg) >>>> + beg >>>> + (save-excursion >>>> + (goto-char (minibuffer-prompt-end)) >>>> + (search-forward beg)))) >>>> + (end (if (number-or-marker-p end) >>>> + end >>>> + (save-excursion >>>> + (goto-char (point-max)) >>>> + (search-backward end))))) >>> >>> What if there are several matches for `beg` and/or for `end` in >>> the buffer? How do we know we got the intended one? >> >> IIUC part of the purpose of using strings rather than positions is to >> account for the case where the text was modified between the moment the >> *Completions* list was created and the moment the user selects one of >> the options. So another question is what to do if the search fails (the >> above code signals an error in that case, which is probably not what we >> want). > > That is a good question. That would happen, I guess, if you had selected > multiple candidates in a CRM, started completing, then deleted the > previously entered candidates, then selected one. I suppose I'd expect > it to add the completed candidate to the end of the remaining list? > So something like > > (let ((beg (if (number-or-marker-p beg) > beg > (save-excursion > (goto-char (minibuffer-prompt-end)) > (or (search-forward beg nil t) > (search-forward-regexp crm-separator nil t) > (minibuffer-prompt-end))))) This makes it specific to CRM. I think we should try and think more locally, without paying too much attention about the various possible external cases: what do we want the `beg` and `end` strings to *mean*? Maybe instead of strings, they should be functions, so CRM can set them to functions that first look for the separator and then search for some leading/trailing string? Stefan