From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: TypeScript support for tree-sitter (was Re: Call for volunteers: add tree-sitter support to major modes) Date: Tue, 11 Oct 2022 09:26:19 -0400 Message-ID: References: <83czb1jrm3.fsf@gnu.org> <87h70b8zqs.fsf@thornhill.no> <835ygrhd1p.fsf@gnu.org> <87bkqj8w8n.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13575"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , Theodor Thornhill , casouri@gmail.com, Matus Goljer To: Theodor Thornhill via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 15:45:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiFZO-0003CT-P1 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 15:45:18 +0200 Original-Received: from localhost ([::1]:39630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiFZN-0005E0-9F for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:45:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiFHD-00036I-5e for emacs-devel@gnu.org; Tue, 11 Oct 2022 09:26:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiFH7-0006PS-Tq; Tue, 11 Oct 2022 09:26:30 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0FD60100138; Tue, 11 Oct 2022 09:26:23 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E854D1000D5; Tue, 11 Oct 2022 09:26:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665494780; bh=HYyt9WLhPA9/XQvKc6zMc0FpK5typDGz8FEHZzB6OiM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=m1PrLwRCvgOg57xpzKIzyM3+KtjNoWj3rcVO6/7XIVnJqB0T7JytoeXUUZ9wzA9GR onnwSMc4FelY1spn5ZpF9t9nyddHe6wOHaGd24AkGeUiFaBJORLAiVCUo/OMcka9y+ 6hHF2+P/aRgzGMZH6zn85qOYLBoUSXoqrWK34YkeLEAN17Dw6FNbWTUMbHJ6HTe2d4 AxyK97ZCj9PBAgqcCYgw//J0BEbuS+HfB42yS6biZAxU3A4THi/8whuQlKQ/CRpoRt 3dsxtgPr3S1W3z8AEkdYn1H4VGjdKv0aBITTlCTlJ37g22lE9VsmDGxYS+LHIPiRyZ c+ixKKPO1oCVQ== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B6A12120623; Tue, 11 Oct 2022 09:26:20 -0400 (EDT) In-Reply-To: <87bkqj8w8n.fsf@thornhill.no> (Theodor Thornhill via's message of "Mon, 10 Oct 2022 18:43:52 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297483 Archived-At: > See attached patch. I believe this should adhere to Yuan Fu's > standards aswell. The function name `typescript-mode` is already taken by NonGNU ELPA's `typescript-mode` package. Please coordinate with that package's author to avoid imposing on the user the need to resolve that conflict. The ideal way is to merge the two so there's only one. [ And the second best is to kill one of the two, so there's only one. ] If the administrative hurdles make it impossible (i.e. we can't bring `typescript-mode` into Emacs core and we're not willing to forgo having that tree-sitter support in core), maybe the next best would be something like: use another name for Emacs's built-in mode then adjust `typescript-mode.el` to derive from `ts-mode` with enough backward compatibility filling to make it not too painful for the end users. For the sake of end-users I strongly recommend we try and merge the two. Please, please, pretty please, Stefan