From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: newbie hacker question: how to add eval-to-texinfo? Date: 03 May 2004 09:12:59 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <16530.10875.904404.67698@termi.eui.upm.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1083590142 8578 80.91.224.253 (3 May 2004 13:15:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 May 2004 13:15:42 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 03 15:15:24 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKdI4-00004r-00 for ; Mon, 03 May 2004 15:15:24 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKdI3-0007xZ-00 for ; Mon, 03 May 2004 15:15:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKdGT-0006jE-55 for emacs-devel@quimby.gnus.org; Mon, 03 May 2004 09:13:45 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BKdGI-0006iN-R7 for emacs-devel@gnu.org; Mon, 03 May 2004 09:13:34 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BKdFl-0006aM-KF for emacs-devel@gnu.org; Mon, 03 May 2004 09:13:33 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKdFl-0006a3-5r; Mon, 03 May 2004 09:13:01 -0400 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 5799B21038; Mon, 3 May 2004 09:12:59 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 446368C6AE; Mon, 3 May 2004 09:12:59 -0400 (EDT) Original-To: jemarch@gnu.org In-Reply-To: <16530.10875.904404.67698@termi.eui.upm.es> Original-Lines: 35 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-0.001, requis 5, BAYES_40 -0.00) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22613 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22613 > I want to add a function called 'eval-to-texi' to emacs (i already > signed papers for that). The name does not make it very clear to me what it does. Could you explain? > - I suppose texinfo.el is the right way to add it. =C2=BFIt is right?. Depends on the patch. But it's a very minor issue. Most patches are not applied as is but are first sent back for a few minor changes: just send the patch and we'll tell you what needs to be changed, if anything. > - All functions in texinfo.el start with a 'texinfo-' prefix. May i to > set that prefix to 'eval-to-texi' naming it 'texinfo-eval-to-texi'? Again, depends on the patch. > - May i to include an autoload for 'eval-to-texi'? I don't see why not. > - To make the patch in unidiff format, would be right to generate it > using 'cvs diff texinfo.el' on a fresh emacs cvs checkout? Or from > the root directory: 'cvs diff lisp/textmodes/texinfo.el' Same difference. =20 > - May i to add an entry to lisp/ChangeLog and send a patch for it too? Better to send the ChangeLog entry separately, but in a patch is also acceptable. In most cases the patch is wrong (because the date needs to be changed, the file has changed in the mean time, etc..) so it has to be inserted by hand anyway. Stefan