From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Peter Dyballa <Peter_Dyballa@Freenet.DE>, emacs-devel@gnu.org
Subject: Re: 23.0.50; dbus
Date: Tue, 01 Jan 2008 22:06:07 -0500 [thread overview]
Message-ID: <jwvlk799bgg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k5mufsl7.fsf@gmx.de> (Michael Albinus's message of "Mon, 31 Dec 2007 22:43:32 +0100")
> Here I'm lost. I use something like
> if (NILP (uname) || (strlen (SDATA (uname)) > 0))
> uname is a Lisp_Object. SDATA (uname) returns (char *). What kind of
> signedness do I break in strlen? Does anybody have an idea?
Someone else already answered the question, but I'll just take the
opportunity to point out that the above code is a common small bug:
the strlen may crash if uname is neither nil nor a string.
A better way to write such code is
if (STRINGP (uname) && (strlen (SDATA (uname)) > 0))
Another benefit is that the compiler can do a better job of
eliminating the (now) redundant STRINGP test that may lurk
inside SDATA.
Stefan
next prev parent reply other threads:[~2008-01-02 3:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 12:00 23.0.50; dbus Peter Dyballa
2007-12-10 12:24 ` William Xu
2007-12-10 12:47 ` Jason Rumney
2007-12-10 12:56 ` Jason Rumney
2007-12-14 21:58 ` Michael Albinus
2007-12-15 10:41 ` Peter Dyballa
2007-12-16 22:57 ` Michael Albinus
2007-12-17 11:04 ` Peter Dyballa
2007-12-17 11:38 ` Michael Albinus
2007-12-21 0:05 ` Stefan Monnier
2007-12-21 19:49 ` Richard Stallman
2007-12-23 16:10 ` Peter Dyballa
2007-12-31 21:43 ` Michael Albinus
2007-12-31 22:26 ` Andreas Schwab
2008-01-01 10:46 ` Michael Albinus
2008-01-01 11:28 ` Peter Dyballa
2008-01-02 3:06 ` Stefan Monnier [this message]
2008-01-02 5:10 ` Michael Albinus
2008-01-02 11:40 ` Thien-Thi Nguyen
2008-01-02 12:48 ` Michael Albinus
2008-01-02 13:41 ` Thien-Thi Nguyen
2008-01-02 15:01 ` Stefan Monnier
2008-01-02 23:32 ` Michael Albinus
2008-01-02 23:59 ` Peter Dyballa
2008-01-03 12:28 ` Jan Djärv
2008-01-05 15:25 ` Peter Dyballa
2007-12-24 12:43 ` Peter Dyballa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlk799bgg.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=Peter_Dyballa@Freenet.DE \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).