From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Wed, 12 Nov 2008 14:42:30 -0500 Message-ID: References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> <86tzacg8yc.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226518971 6900 80.91.229.12 (12 Nov 2008 19:42:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Nov 2008 19:42:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 12 20:43:54 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0Ld3-0002mq-QW for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 20:43:54 +0100 Original-Received: from localhost ([127.0.0.1]:40801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0Lbv-0005v1-Se for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 14:42:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0Lbm-0005r4-Vf for emacs-devel@gnu.org; Wed, 12 Nov 2008 14:42:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0Lbl-0005pI-9M for emacs-devel@gnu.org; Wed, 12 Nov 2008 14:42:34 -0500 Original-Received: from [199.232.76.173] (port=51343 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0Lbl-0005pC-1d for emacs-devel@gnu.org; Wed, 12 Nov 2008 14:42:33 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:44431 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0Lbk-0006Jf-Pj for emacs-devel@gnu.org; Wed, 12 Nov 2008 14:42:32 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEANDAGklFxLQU/2dsb2JhbACBds8Xg1eBEQ X-IronPort-AV: E=Sophos;i="4.33,591,1220241600"; d="scan'208";a="29786198" Original-Received: from 69-196-180-20.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.20]) by ironport2-out.teksavvy.com with ESMTP; 12 Nov 2008 14:42:32 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7497784CE; Wed, 12 Nov 2008 14:42:30 -0500 (EST) In-Reply-To: <86tzacg8yc.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 12 Nov 2008 11:17:31 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105610 Archived-At: > I think that should be up to the user, to be done in the hook. The > information, diff and files added/removed/affected, exists outside the > commit message so putting it inside the message duplicates the > information. Agreed. One missing feature OTOH is a way to get from the log-edit buffer to the patch that's being committed. With PCL-CVS you can use C-x c = to get it, but in general it's missing. > I see your point and agree. How about this patch to just call > log-edit-insert-changelog? I call it regardless of the SETUP parameter, > but it could follow the erase-buffer call instead. I'd rather just change the default value of the hook, so that users can remove that entry from the hook if they don't want it run. Stefan