From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Warning when byte-compiling simple.el Date: Fri, 13 Nov 2009 09:50:38 -0500 Message-ID: References: <83fx8ioh60.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1258123877 9320 80.91.229.12 (13 Nov 2009 14:51:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2009 14:51:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 13 15:51:10 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N8xUA-0003Nc-Q1 for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2009 15:50:51 +0100 Original-Received: from localhost ([127.0.0.1]:43315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8xUA-0000Rm-EE for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2009 09:50:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8xU4-0000RH-Tj for emacs-devel@gnu.org; Fri, 13 Nov 2009 09:50:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8xU0-0000QT-VF for emacs-devel@gnu.org; Fri, 13 Nov 2009 09:50:44 -0500 Original-Received: from [199.232.76.173] (port=38046 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8xU0-0000QQ-QS for emacs-devel@gnu.org; Fri, 13 Nov 2009 09:50:40 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:15358 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8xTz-0006D5-Ij; Fri, 13 Nov 2009 09:50:39 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqwEAF8B/UpFpYg5/2dsb2JhbACBTdQ/hDwEiTY X-IronPort-AV: E=Sophos;i="4.44,737,1249272000"; d="scan'208";a="49353399" Original-Received: from 69-165-136-57.dsl.teksavvy.com (HELO pastel.home) ([69.165.136.57]) by ironport2-out.pppoe.ca with ESMTP; 13 Nov 2009 09:50:39 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D17CD7F82; Fri, 13 Nov 2009 09:50:38 -0500 (EST) In-Reply-To: <83fx8ioh60.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Nov 2009 12:25:27 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116949 Archived-At: > In minibuffer-default-add-completions: > simple.el:1375:15:Warning: all-completions called with 4 arguments, but > accepts only 2-3 > This warning is a lie: all-completions accepts 2 to 4 arguments. I > don't think we should lie about that; if we want to deprecate the 4th > argument, we should find a better way of conveying this to its users. I guess the warning should use a more informative message, indeed. > In any case, we shouldn't call it with 4 arguments ourselves, > certainly not in such a core file as simple.el. Agreed. So the warning worked: it caught this use ;-) Stefan