From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Type-error in C code Date: Fri, 12 Nov 2010 16:00:15 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289855167 3936 80.91.229.12 (15 Nov 2010 21:06:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 15 Nov 2010 21:06:07 +0000 (UTC) Cc: Julien Danjou , Jan =?iso-8859-1?Q?Dj=E4rv?= , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 15 22:06:01 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PI6FV-0007sb-Ci for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2010 22:06:01 +0100 Original-Received: from localhost ([127.0.0.1]:34937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI6FU-0004SB-H0 for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2010 16:06:00 -0500 Original-Received: from [140.186.70.92] (port=58370 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI6F6-0004MS-1H for emacs-devel@gnu.org; Mon, 15 Nov 2010 16:05:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI6Es-0003YT-KM for emacs-devel@gnu.org; Mon, 15 Nov 2010 16:05:35 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:58400 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI6Es-0003Y0-Dn for emacs-devel@gnu.org; Mon, 15 Nov 2010 16:05:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0GAA4v4UxFpY76/2dsb2JhbAChXH1ywDuFSgSEWo1f X-IronPort-AV: E=Sophos;i="4.59,201,1288584000"; d="scan'208";a="82622101" Original-Received: from 69-165-142-250.dsl.teksavvy.com (HELO ceviche.home) ([69.165.142.250]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Nov 2010 16:05:21 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3ED4F662AF; Fri, 12 Nov 2010 16:00:15 -0500 (EST) In-Reply-To: (Andreas Schwab's message of "Fri, 12 Nov 2010 19:45:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132654 Archived-At: >> The error is to put an "Atom" into a cons cell: those can only hold >> Lisp_Objects. The usual compilation flags won't catch the error because >> both types are actually some kind of integer, but if you >> compile --enable-use-lisp-union-type, the C compiler will >> dutyfully burp. > I think we should remove the union Lisp_Object, and instead define a > struct Lisp_Object { EMACS_INT i; } (reusing the macros of the non-union > type), and make that the default Lisp_Object at least during > development. Not sure what we be the benefit. Stefan