From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111707: * doc-view.el: Use (and prefer) soffice as default ODF->PDF Date: Sat, 09 Feb 2013 09:26:21 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360419991 12353 80.91.229.3 (9 Feb 2013 14:26:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Feb 2013 14:26:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 09 15:26:52 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U4BOA-0004j6-89 for ged-emacs-devel@m.gmane.org; Sat, 09 Feb 2013 15:26:46 +0100 Original-Received: from localhost ([::1]:52704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4BNr-00005X-0r for ged-emacs-devel@m.gmane.org; Sat, 09 Feb 2013 09:26:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4BNo-00005L-5p for emacs-devel@gnu.org; Sat, 09 Feb 2013 09:26:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4BNn-0006y4-2X for emacs-devel@gnu.org; Sat, 09 Feb 2013 09:26:24 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4BNm-0006y0-V6; Sat, 09 Feb 2013 09:26:23 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAScvIwULCw4mBwsUDQsNJBOHfwMJBrdLDYlVjBKEeAOIYYtWjQ+DNIFegxU X-IPAS-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAScvIwULCw4mBwsUDQsNJBOHfwMJBrdLDYlVjBKEeAOIYYtWjQ+DNIFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="860578" Original-Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 09 Feb 2013 09:26:21 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id EA486593BF; Sat, 9 Feb 2013 09:26:21 -0500 (EST) In-Reply-To: (Tassilo Horn's message of "Sat, 09 Feb 2013 10:58:48 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156922 Archived-At: > committer: Tassilo Horn > branch nick: trunk > timestamp: Sat 2013-02-09 10:58:48 +0100 > message: > * doc-view.el: Use (and prefer) soffice as default ODF->PDF > converter (Bug#13622). Patch provided by Jambunathan K > . > (doc-view-unoconv-program): Make obsolete variable. > (doc-view-odf->pdf-converter-program): New variable. > (doc-view-odf->pdf-converter-function): New variable. > (doc-view-mode-p): Use it. > (doc-view-odf->pdf-converter-unoconv): Rename from > `doc-view-odf->pdf-converter-unoconv'. > (doc-view-odf->pdf-converter-soffice): New function. > (doc-view-convert-current-doc): Use > `doc-view-odf->pdf-converter-function'. > modified: > lisp/ChangeLog > lisp/doc-view.el > === modified file 'lisp/ChangeLog' > --- a/lisp/ChangeLog 2013-02-09 05:52:20 +0000 > +++ b/lisp/ChangeLog 2013-02-09 09:58:48 +0000 > @@ -1,3 +1,18 @@ > +2013-02-09 Tassilo Horn > + > + * doc-view.el: Use (and prefer) soffice as default ODF->PDF > + converter (Bug#13622). Patch provided by Jambunathan K > + . > + (doc-view-unoconv-program): Make obsolete variable. > + (doc-view-odf->pdf-converter-program): New variable. > + (doc-view-odf->pdf-converter-function): New variable. > + (doc-view-mode-p): Use it. > + (doc-view-odf->pdf-converter-unoconv): Rename from > + `doc-view-odf->pdf-converter-unoconv'. > + (doc-view-odf->pdf-converter-soffice): New function. > + (doc-view-convert-current-doc): Use > + `doc-view-odf->pdf-converter-function'. This change log is wrong, since it says you're the author. It should instead start with 2013-02-09 Jambunathan K This said, I have another question: assuming both soffice and unoconv are installed. Which of the two is preferable and why (e.g. faster or gives better output)? Stefan