From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115470: eww: exit and close actions Date: Fri, 13 Dec 2013 21:07:00 -0500 Message-ID: References: <87haadq3pn.fsf@flea.lifelogs.com> <878uvoq0md.fsf@flea.lifelogs.com> <8761qso84n.fsf@flea.lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386986837 19402 80.91.229.3 (14 Dec 2013 02:07:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Dec 2013 02:07:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 14 03:07:22 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VredV-0002Fx-TY for ged-emacs-devel@m.gmane.org; Sat, 14 Dec 2013 03:07:22 +0100 Original-Received: from localhost ([::1]:45374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VredV-0003qE-At for ged-emacs-devel@m.gmane.org; Fri, 13 Dec 2013 21:07:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VredL-0003q9-Uy for emacs-devel@gnu.org; Fri, 13 Dec 2013 21:07:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VredE-0008PF-Km for emacs-devel@gnu.org; Fri, 13 Dec 2013 21:07:11 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VredE-0008P9-Fq for emacs-devel@gnu.org; Fri, 13 Dec 2013 21:07:04 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBE2714B016696; Fri, 13 Dec 2013 21:07:02 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id DBB2CAE21D; Fri, 13 Dec 2013 21:07:00 -0500 (EST) In-Reply-To: <8761qso84n.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Fri, 13 Dec 2013 14:36:56 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4791=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4791> : inlines <324> : streams <1090481> : uri <1623307> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166380 Archived-At: > I agree the current implementation is suboptimal but your problem is > with the fundamental idea of separating "close" from "exit." No, the problem is with calling eww-close instead of quit-window, and with calling eww-exit instead of kill-this-buffer. To me, this is just obfuscation. > - revert back to `q' being `quit-window', Yes. As I said elsewhere, I think this binding should basically be inherited from special-mode-map. > - no "close" or "exit" concepts Yup. > - implement some way to quit all eww windows for privacy and security If someone wants that, I'm not opposed to it (tho "quitting all windows" won't give you any privacy or security benefits, so it will presumably do something else). But I wouldn't call it "exit". The name should instead include something like clear/wipe/flush/... > - implement "close" and "exit" differently but still try to separate them As explained in my previous email those two concepts don't make sense in the context of eww, so those names shouldn't be used. Stefan