From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view. Date: Mon, 06 Jan 2014 10:05:21 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389020743 4099 80.91.229.3 (6 Jan 2014 15:05:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jan 2014 15:05:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 06 16:05:49 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0BkS-0007b7-KX for ged-emacs-devel@m.gmane.org; Mon, 06 Jan 2014 16:05:48 +0100 Original-Received: from localhost ([::1]:35730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0BkS-0005F5-4t for ged-emacs-devel@m.gmane.org; Mon, 06 Jan 2014 10:05:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0BkD-0005ET-DZ for emacs-devel@gnu.org; Mon, 06 Jan 2014 10:05:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Bk2-0000iA-F8 for emacs-devel@gnu.org; Mon, 06 Jan 2014 10:05:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:2607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Bk2-0000i6-7v for emacs-devel@gnu.org; Mon, 06 Jan 2014 10:05:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag8KABK/CFFFxKG9/2dsb2JhbABEvgwEA3sXc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Ag8KABK/CFFFxKG9/2dsb2JhbABEvgwEA3sXc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="44219979" Original-Received: from 69-196-161-189.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.189]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Jan 2014 10:05:21 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 91E5762F04; Mon, 6 Jan 2014 10:05:21 -0500 (EST) In-Reply-To: (Daniel Colascione's message of "Mon, 06 Jan 2014 07:34:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167470 Archived-At: > + Fix defun navigation in vc log view. [...] > (if (< arg 0) > + (log-view-end-of-defun (- arg)) This looks very fishy. beginning-of-defun-function should never move to the end of a defun, even when called with a negative argument. So, if this is really correct, it needs a comment explaining why this is the right thing to do. And if you could add some regression tests for your commit it would be even better. Stefan