From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view.
Date: Mon, 06 Jan 2014 10:05:21 -0500 [thread overview]
Message-ID: <jwvlhytrw5f.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1W04hL-0002hZ-NE@vcs.savannah.gnu.org> (Daniel Colascione's message of "Mon, 06 Jan 2014 07:34:07 +0000")
> + Fix defun navigation in vc log view.
[...]
> (if (< arg 0)
> + (log-view-end-of-defun (- arg))
This looks very fishy. beginning-of-defun-function should never move to
the end of a defun, even when called with a negative argument.
So, if this is really correct, it needs a comment explaining why this is
the right thing to do. And if you could add some regression tests for your
commit it would be even better.
Stefan
next parent reply other threads:[~2014-01-06 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W04hL-0002hZ-NE@vcs.savannah.gnu.org>
2014-01-06 15:05 ` Stefan Monnier [this message]
2014-01-06 15:08 ` [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlhytrw5f.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).