From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char. Date: Thu, 19 Mar 2015 16:04:59 -0400 Message-ID: References: <20150318194629.7043.70347@vcs.savannah.gnu.org> <873850258s.fsf@lenovog410.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426795546 2463 80.91.229.3 (19 Mar 2015 20:05:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Mar 2015 20:05:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: vibhavp@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 19 21:05:37 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYghA-00055N-GE for ged-emacs-devel@m.gmane.org; Thu, 19 Mar 2015 21:05:32 +0100 Original-Received: from localhost ([::1]:41063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYgh4-00023b-QN for ged-emacs-devel@m.gmane.org; Thu, 19 Mar 2015 16:05:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYggl-00020x-B7 for emacs-devel@gnu.org; Thu, 19 Mar 2015 16:05:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYggg-0008LH-Pd for emacs-devel@gnu.org; Thu, 19 Mar 2015 16:05:07 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:52961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYggg-0008KW-Kj for emacs-devel@gnu.org; Thu, 19 Mar 2015 16:05:02 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2JK4xw6031609; Thu, 19 Mar 2015 16:04:59 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6B156182C; Thu, 19 Mar 2015 16:04:59 -0400 (EDT) In-Reply-To: <873850258s.fsf@lenovog410.lan> (vibhavp@gmail.com's message of "Fri, 20 Mar 2015 00:18:19 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5250=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5250> : inlines <2449> : streams <1408210> : uri <1884908> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184026 Archived-At: > - * lisp/leim/quail/hangul.el > - * lisp/progmodes/cperl-mode.el: Use delete-char instead of > + * lisp/leim/quail/hangul.el (hangul-delete-backward-char) > + (hangul-to-hanja-conversion): > + * lisp/progmodes/cperl-mode.el (cperl-electric-keyword) > + (cperl-electric-backspace): Use delete-char instead of > delete-backward-char, fixes compilation warnings. Looks good, thanks. > - (delete-char (- arg)))))) > + (call-interactively 'delete-backward-char))))) FWIW, my suggestion to use call-interactively was just that: a suggestion. I don't know this cperl's command well enough to know what should ideally be done. It might even be that using delete-char really is The Right Thing. Noone can know which is right before he/she looks at the function in enough detail to know how&when the various alternatives will behave differently (after which it's generally easy to figure out which one is best). Stefan