From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 4d3a595: `load-path' should contain only directory names Date: Wed, 28 Oct 2015 12:30:27 -0400 Message-ID: References: <20151023135532.11512.53356@vcs.savannah.gnu.org> <83mvv8wejc.fsf@gnu.org> <86bnboeymw.fsf@stephe-leake.org> <83wpuadc9k.fsf@gnu.org> <86d1w1ahsy.fsf@stephe-leake.org> <562E2A8A.1030601@yandex.ru> <83wpu9bns4.fsf@gnu.org> <86fv0x8kl6.fsf@stephe-leake.org> <83d1w0416d.fsf@gnu.org> <8337ww3ypz.fsf@gnu.org> <83vb9r2ddg.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446049873 30953 80.91.229.3 (28 Oct 2015 16:31:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Oct 2015 16:31:13 +0000 (UTC) Cc: dgutov@yandex.ru, stephen_leake@stephe-leake.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 28 17:31:01 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZrTcn-0002FF-J7 for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 17:30:57 +0100 Original-Received: from localhost ([::1]:39320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrTcm-0002nh-6s for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 12:30:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrTcQ-0002nX-Nb for emacs-devel@gnu.org; Wed, 28 Oct 2015 12:30:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrTcM-0003n0-H4 for emacs-devel@gnu.org; Wed, 28 Oct 2015 12:30:34 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:58054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrTcM-0003mj-73; Wed, 28 Oct 2015 12:30:30 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t9SGUSVA004441; Wed, 28 Oct 2015 12:30:28 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id E0B3B66349; Wed, 28 Oct 2015 12:30:27 -0400 (EDT) In-Reply-To: <83vb9r2ddg.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Oct 2015 17:59:07 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5473=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5473> : inlines <3953> : streams <1528857> : uri <2071976> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192804 Archived-At: >> > The manual says "directory name" ends in a slash, and talks about >> > "file name of a directory" which doesn't. >> I don't think we generally use the term "directory name" in such >> a strict sense. At the very least, in all these years, I never noticed >> that this term had such a precise meaning and it's never bitten me. > It's a very old confusion, yes. But that doesn't mean IMO that we > shouldn't try to fix it, at least in those places where it's > important. Like this one. In which way is it important for load-path? > If you disagree that this situation is confusing, I guess we will have > to agree to disagree, because it sounds confusing to me, and it surely > confused Stephen, who is not exactly a newbie. The problem here is in the manual: "directory name" is a general term used in the POSIX world and beyond, and it usually doesn't care whether there's a trailing slash. There are a few particular situations where the difference matters, indeed, but rather than co-opt the generally known term and load it with a more precise semantics than is usual, I'd prefer that we introduce new names for "directory name with a slash" and "directory name without a slash". And in all the cases where the difference shouldn't matter because there's no ambiguity, then we shouldn't add extra restrictions. > The changes to the doc string and to the manual were intended to > rectify this confusion. We now define another term, "directory file > name", That's fine to define "directory name without a slash". > and use it in the doc string of load-path, That's wrong, because an element of load-path may (or may not) have a trailing slash and we should (and do) handle both cases correctly as well, and all users of load-path (e.g. Stephen's code) should also handle both cases. Stefan