From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jackson Hamilton <jackson@jacksonrayhamilton.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile
Date: Sat, 06 Aug 2016 14:29:42 -0400 [thread overview]
Message-ID: <jwvlh09rbwq.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <CAGiE8Ax29WBRa0WY-ueD3yLpeg3xEVr2NZU1xQg_HuQ3+1tx7Q@mail.gmail.com> (Jackson Hamilton's message of "Sat, 6 Aug 2016 10:42:55 -0700")
> The contents of these test fixtures are significant. Changing them caused
> the project's tests to fail.
Hmm... indeed I see that now.
> Can byte compilation be disabled for these
> files without modifying their source? (For instance, by disabling
> byte-compilation for the whole fixtures/ directory? Maybe through
> .dir-locals.el? Or maybe by respecting .elpaignore?)
Respecting .elpaignore would be perfect, indeed. But that file is using
a format defined by tar, whereas I'd need to tweak the GNUmakefile rules
to understand it, which is rather tricky.
I'll see what I can come up with.
Stefan
> On Thu, Aug 4, 2016 at 6:37 PM, Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>> branch: master
>> commit b7d8d3ca7f1bc279a3e8b21646ccea481c93ed46
>> Author: Stefan Monnier <monnier@iro.umontreal.ca>
>> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>>
>> * fixtures/test/: Don't byte-compile
>> ---
>> packages/context-coloring/fixtures/test/cond.el | 1
>> +
>> packages/context-coloring/fixtures/test/condition-case.el | 1
>> +
>> packages/context-coloring/fixtures/test/defun.el | 1
>> +
>> packages/context-coloring/fixtures/test/ignored.el | 1
>> +
>> packages/context-coloring/fixtures/test/let.el | 1
>> +
>> packages/context-coloring/fixtures/test/macroexp-let2.el | 1
>> +
>> packages/context-coloring/fixtures/test/unbalanced-parenthesis.el | 1
>> +
>> packages/context-coloring/fixtures/test/varlist-spacing.el | 1
>> +
>> 8 files changed, 8 insertions(+)
>>
>> diff --git a/packages/context-coloring/fixtures/test/cond.el
>> b/packages/context-coloring/fixtures/test/cond.el
>> index d5aae5b..5ed1ec2 100644
>> --- a/packages/context-coloring/fixtures/test/cond.el
>> +++ b/packages/context-coloring/fixtures/test/cond.el
>> @@ -1,3 +1,4 @@
>> +;; -*- no-byte-compile:t' -*-
>> (let (a)
>> (cond
>> (a t)
>> diff --git a/packages/context-coloring/fixtures/test/condition-case.el
>> b/packages/context-coloring/fixtures/test/condition-case.el
>> index 151f591..56a5f44 100644
>> --- a/packages/context-coloring/fixtures/test/condition-case.el
>> +++ b/packages/context-coloring/fixtures/test/condition-case.el
>> @@ -1,3 +1,4 @@
>> +;; -*- no-byte-compile:t' -*-
>> (condition-case err
>> (progn err free)
>> (error err free)
>> diff --git a/packages/context-coloring/fixtures/test/defun.el
>> b/packages/context-coloring/fixtures/test/defun.el
>> index 10a52f6..173ba0b 100644
>> --- a/packages/context-coloring/fixtures/test/defun.el
>> +++ b/packages/context-coloring/fixtures/test/defun.el
>> @@ -1,3 +1,4 @@
>> +;; -*- no-byte-compile:t' -*-
>> (defun abc (def ghi &optional jkl)
>> (+ def ghi jkl free))
>>
>> diff --git a/packages/context-coloring/fixtures/test/ignored.el
>> b/packages/context-coloring/fixtures/test/ignored.el
>> index 1f5fd42..0c540ff 100644
>> --- a/packages/context-coloring/fixtures/test/ignored.el
>> +++ b/packages/context-coloring/fixtures/test/ignored.el
>> @@ -1,2 +1,3 @@
>> +;; -*- no-byte-compile:t' -*-
>> (defun a ()
>> (+ a 1 +1 -1 1.0 #x0 ,a :a t nil (0 . 0)))
>> diff --git a/packages/context-coloring/fixtures/test/let.el
>> b/packages/context-coloring/fixtures/test/let.el
>> index 49edb50..761a265 100644
>> --- a/packages/context-coloring/fixtures/test/let.el
>> +++ b/packages/context-coloring/fixtures/test/let.el
>> @@ -1,3 +1,4 @@
>> +;; -*- no-byte-compile:t' -*-
>> (let (a
>> (b a)
>> (c free)
>> diff --git a/packages/context-coloring/fixtures/test/macroexp-let2.el
>> b/packages/context-coloring/fixtures/test/macroexp-let2.el
>> index 1b61df2..97fbb23 100644
>> --- a/packages/context-coloring/fixtures/test/macroexp-let2.el
>> +++ b/packages/context-coloring/fixtures/test/macroexp-let2.el
>> @@ -1,3 +1,4 @@
>> +;; -*- no-byte-compile:t' -*-
>> (let (exp)
>> (macroexp-let2 macroexp-copyable-p v exp
>> v exp))
>> diff --git a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>> b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>> index caaf7e2..e028aef 100644
>> --- a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>> +++ b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>> @@ -1,2 +1,3 @@
>> +;; -*- no-byte-compile:t' -*-
>> (let ())
>> (let ()
>> diff --git a/packages/context-coloring/fixtures/test/varlist-spacing.el
>> b/packages/context-coloring/fixtures/test/varlist-spacing.el
>> index 97ec208..399cd18 100644
>> --- a/packages/context-coloring/fixtures/test/varlist-spacing.el
>> +++ b/packages/context-coloring/fixtures/test/varlist-spacing.el
>> @@ -1,3 +1,4 @@
>> +;; -*- no-byte-compile:t' -*-
>> (let (
>> (a (lambda ()))))
>>
>>
next prev parent reply other threads:[~2016-08-06 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160805013757.31623.20092@vcs.savannah.gnu.org>
[not found] ` <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org>
2016-08-06 17:42 ` [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Jackson Hamilton
2016-08-06 18:29 ` Stefan Monnier [this message]
2016-12-18 0:06 ` Jackson Ray Hamilton
2016-12-18 3:18 ` Stefan Monnier
2016-12-19 2:43 ` Jackson Ray Hamilton
2016-12-19 14:49 ` Stefan Monnier
2016-12-20 6:04 ` Jackson Ray Hamilton
2016-12-20 14:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlh09rbwq.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jackson@jacksonrayhamilton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).