From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Thu, 08 Sep 2016 13:47:46 -0400 Message-ID: References: <20160907153014.15752-1-toke@toke.dk> <87inu7k5z4.fsf@toke.dk> <83bmzzaawr.fsf@gnu.org> <877fank1oc.fsf@toke.dk> <87inu6iim8.fsf@toke.dk> <2563921f-d20d-753b-09eb-c8671bc5b6d6@yandex.ru> <87a8fiidso.fsf@toke.dk> <83oa3y8g0x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1473358094 29713 195.159.176.226 (8 Sep 2016 18:08:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2016 18:08:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Toke =?windows-1252?Q?H=F8iland-J=F8rgensen?= , emacs-devel@gnu.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 08 20:08:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi3k7-00071t-1w for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 20:08:07 +0200 Original-Received: from localhost ([::1]:50188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3k4-0007wb-VJ for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 14:08:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3NP-0002EV-7i for emacs-devel@gnu.org; Thu, 08 Sep 2016 13:44:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi3NM-0000El-Js for emacs-devel@gnu.org; Thu, 08 Sep 2016 13:44:39 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:51844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3NM-0000ES-Fb; Thu, 08 Sep 2016 13:44:36 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u88HjIvW029166; Thu, 8 Sep 2016 13:45:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 014786006A; Thu, 8 Sep 2016 13:47:46 -0400 (EDT) In-Reply-To: <83oa3y8g0x.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2016 20:20:30 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5791=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5791> : inlines <5197> : streams <1697359> : uri <2284769> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207294 Archived-At: > If that file is guaranteed to be pure ASCII, we can indeed force the > string returned by url-cookie-generate-header to be unibyte. > Otherwise we need to encode it. AFAIK the cookie data is "sequence of bytes", i.e. not "pure ASCII". And yes the domain names may include non-ASCII characters, so we have to encode those somehow (unless the URL library already encodes them for us before url-cookie receives them). Stefan