unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jackson Ray Hamilton <takua95@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>,
	Jackson Hamilton <jackson@jacksonrayhamilton.com>
Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile
Date: Sat, 17 Dec 2016 22:18:41 -0500	[thread overview]
Message-ID: <jwvlgvehr3p.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <357c3d56-6fe1-fcd1-8403-eaab95ab9af8@gmail.com> (Jackson Ray Hamilton's message of "Sat, 17 Dec 2016 16:06:38 -0800")

> Apparently, tar uses gnulib's excluded_file_name function, which appears
> to delegate to fnmatch, which looks pretty complex to me.  I'm not aware
> of a "standalone" command providing an interface for this pattern
> matcher, but if one exists, maybe we could utilize that.

I think we could use sh's "case" patterns for that.

> Another option might be to generate an archive with tar and then use the
> list of included files to determine what to compile.  This command:
>
> $ tar -ch packages/context-coloring/ --exclude-vcs -X \
>   packages/context-coloring/.elpaignore | tar --list
>
> Produces this output:

> packages/context-coloring/
> packages/context-coloring/LICENSE
> packages/context-coloring/context-coloring-emacs-lisp.el
> packages/context-coloring/README.md
> packages/context-coloring/context-coloring-javascript.el
> packages/context-coloring/context-coloring.el
>
> We could filter down the ".el" files from there.

That might work as well, indeed.

BTW, given the current GNUmakefile, it's easy/natural to only test
.elpaignore matches for those files which end in .el and which don't yet
have a .elc file.  I expect this would be an important optimization to
make sure that "make" is fast when there's not much to (re)compile.


        Stefan



  reply	other threads:[~2016-12-18  3:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160805013757.31623.20092@vcs.savannah.gnu.org>
     [not found] ` <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org>
2016-08-06 17:42   ` [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Jackson Hamilton
2016-08-06 18:29     ` Stefan Monnier
2016-12-18  0:06       ` Jackson Ray Hamilton
2016-12-18  3:18         ` Stefan Monnier [this message]
2016-12-19  2:43           ` Jackson Ray Hamilton
2016-12-19 14:49             ` Stefan Monnier
2016-12-20  6:04               ` Jackson Ray Hamilton
2016-12-20 14:53                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlgvehr3p.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=jackson@jacksonrayhamilton.com \
    --cc=takua95@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).