From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change.
Date: Sun, 05 Mar 2017 21:53:32 -0500 [thread overview]
Message-ID: <jwvlgsjrudl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83a892n5k8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 03 Mar 2017 10:11:03 +0200")
>> > The 3 variables related to overlay-arrow whose changes need to trigger
>> > redisplay of the respective buffers: overlay-arrow-position,
>> > overlay-arrow-string, and overlay-arrow-bitmap.
>> But that means we need to watch variable assignments, marker
>> modifications, and symbol property modifications. Using overlays gets
>> us all this "for free" because we already watch all overlay modifications.
> Variables and markers, yes. Symbol properties: I don't see why would
> we need to watch them.
overlay-arrow-string and overlay-arrow-bitmap are a symbol properties.
(overlay-arrow-string is *also* a variable, but overlay-arrow-bitmap isn't).
> Anyway, it was just a thought. It sounds like a conceptually simpler,
> even if the implementation is somewhat hairy.
To me the conceptually simpler option is to use overlays (at least, when
I first learned about overlay-arrows many years ago it took me a while
to understand them because I expected them to be represented by special
kinds of overlays).
Stefan
next prev parent reply other threads:[~2017-03-06 2:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 16:10 [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change Eli Zaretskii
2017-02-28 17:47 ` Stefan Monnier
2017-02-28 18:09 ` Eli Zaretskii
2017-02-28 18:58 ` Stefan Monnier
2017-02-28 19:11 ` Eli Zaretskii
2017-02-28 20:02 ` Stefan Monnier
2017-03-01 17:03 ` Eli Zaretskii
2017-03-02 5:27 ` Stefan Monnier
2017-03-02 16:02 ` Eli Zaretskii
2017-03-02 18:29 ` Stefan Monnier
2017-03-02 20:18 ` Eli Zaretskii
2017-03-02 22:32 ` Stefan Monnier
2017-03-03 8:11 ` Eli Zaretskii
2017-03-06 2:53 ` Stefan Monnier [this message]
2017-03-03 8:13 ` Eli Zaretskii
2017-03-06 4:17 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlgsjrudl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).