From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Problem quitting properly from transient keymap with one keystroke Date: Fri, 20 Oct 2017 08:24:36 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508502985 17931 195.159.176.226 (20 Oct 2017 12:36:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Oct 2017 12:36:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 20 14:36:21 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5WX9-0003EY-5B for ged-emacs-devel@m.gmane.org; Fri, 20 Oct 2017 14:36:15 +0200 Original-Received: from localhost ([::1]:53709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5WXG-0007nO-7O for ged-emacs-devel@m.gmane.org; Fri, 20 Oct 2017 08:36:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5WMK-0005dM-0o for emacs-devel@gnu.org; Fri, 20 Oct 2017 08:25:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5WMF-0003rG-0a for emacs-devel@gnu.org; Fri, 20 Oct 2017 08:25:04 -0400 Original-Received: from [195.159.176.226] (port=48802 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5WME-0003mb-P6 for emacs-devel@gnu.org; Fri, 20 Oct 2017 08:24:58 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e5WLu-0005lC-8C for emacs-devel@gnu.org; Fri, 20 Oct 2017 14:24:38 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:3UI+UtyTr8YJc6cYlSWCyxBWdik= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219639 Archived-At: > The problem is that set-transient-map uses pre-command-hook to test the > stay-in-transient-map function and to exit, so if a keystroke sets the > flag read by the stay-in-transient-map function to disable the transient > map, this check is not done until another key is pressed because the > pre-command-hook is not run again until then (so the code doesn't see > the flag change until then). Indeed, that's why I made `set-transient-map` return an "exit function" which you can call when you want to explicitly leave this transient map at a different time than when the `keep-pred` predicate is checked. Stefan