From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Problem quitting properly from transient keymap with one keystroke
Date: Fri, 20 Oct 2017 08:24:36 -0400 [thread overview]
Message-ID: <jwvlgk6nh4j.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: m0wp3r7rtm.rsw@gnu.org
> The problem is that set-transient-map uses pre-command-hook to test the
> stay-in-transient-map function and to exit, so if a keystroke sets the
> flag read by the stay-in-transient-map function to disable the transient
> map, this check is not done until another key is pressed because the
> pre-command-hook is not run again until then (so the code doesn't see
> the flag change until then).
Indeed, that's why I made `set-transient-map` return an "exit function"
which you can call when you want to explicitly leave this transient map
at a different time than when the `keep-pred` predicate is checked.
Stefan
next prev parent reply other threads:[~2017-10-20 12:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 3:13 Problem quitting properly from transient keymap with one keystroke Bob Weiner
2017-10-19 15:40 ` Robert Weiner
2017-10-20 12:24 ` Stefan Monnier [this message]
2017-10-20 12:27 ` Stefan Monnier
2017-10-20 14:45 ` Robert Weiner
2017-10-20 15:13 ` Stefan Monnier
2017-10-20 16:04 ` Robert Weiner
2017-10-20 17:34 ` Stefan Monnier
2017-10-20 17:51 ` Robert Weiner
2017-10-20 12:42 ` Oleh Krehel
2017-10-20 14:32 ` Robert Weiner
2017-10-20 14:36 ` Robert Weiner
2017-10-20 14:44 ` Stefan Monnier
2017-10-20 15:26 ` Oleh Krehel
2017-10-20 17:30 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlgk6nh4j.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).