From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.orgmode,gmane.emacs.devel Subject: Re: orgalist-mode: wrong indentation in message mode after recent change in emacs Date: Tue, 02 Apr 2019 07:08:16 -0400 Message-ID: References: <87k1gdptsn.fsf@len.workgroup> <87ef6l9x13.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13270"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Tue Apr 02 13:09:15 2019 Return-path: Envelope-to: geo-emacs-orgmode@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBHI0-0003EN-RG for geo-emacs-orgmode@m.gmane.org; Tue, 02 Apr 2019 13:09:12 +0200 Original-Received: from localhost ([127.0.0.1]:47941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBHHz-0000xg-Q5 for geo-emacs-orgmode@m.gmane.org; Tue, 02 Apr 2019 07:09:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBHHB-0000wb-9U for emacs-orgmode@gnu.org; Tue, 02 Apr 2019 07:08:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBHHA-0004u8-G4 for emacs-orgmode@gnu.org; Tue, 02 Apr 2019 07:08:21 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:55566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBHHA-0004sY-7A; Tue, 02 Apr 2019 07:08:20 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x32B8GSm020898; Tue, 2 Apr 2019 07:08:17 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 616CFAE2AB; Tue, 2 Apr 2019 07:08:16 -0400 (EDT) In-Reply-To: <87ef6l9x13.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 01 Apr 2019 23:32:40 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6516=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6516> : inlines <7045> : streams <1817486> : uri <2824380> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Original-Sender: "Emacs-orgmode" Xref: news.gmane.org gmane.emacs.orgmode:124079 gmane.emacs.devel:234859 Archived-At: > Now that add-function sets indent-line-function to a custom closure, > however, (advice--cd*r indent-line-function) no longer returns > indent-relative and the workaround breaks. I think this qualifies as a problem in nadvice: the ad-hoc closure introduced to "redirect to the default-value" should be handled by advice--cd*r (or rather by some new function which can then be used instead of advice--cd*r). Stefan