From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Predicate for true lists Date: Tue, 09 Apr 2019 12:32:16 -0400 Message-ID: References: <87fu3vdjjk.fsf@tcd.ie> <87bmcqhhsf.fsf@tcd.ie> <87in6xgtpb.fsf@tcd.ie> <2af892df-26cb-60b2-4fd8-067fcb3d32e9@cs.ucla.edu> <87r2kh9uwx.fsf@tcd.ie> <83h8lcnbxb.fsf@gnu.org> <87sh4s9poo.fsf@tcd.ie> <87k1q49p0i.fsf@tcd.ie> <87efgbbq2p.fsf@tcd.ie> <87a7gz8hp2.fsf@tcd.ie> <87mukzb173.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235042"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 18:38:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDtlk-000z23-M6 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 18:38:44 +0200 Original-Received: from localhost ([127.0.0.1]:46178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDtlj-0007nk-Nw for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 12:38:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDtfe-00045F-0z for emacs-devel@gnu.org; Tue, 09 Apr 2019 12:32:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDtfd-00015q-7Y for emacs-devel@gnu.org; Tue, 09 Apr 2019 12:32:26 -0400 Original-Received: from [195.159.176.226] (port=42954 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDtfc-00014F-Rs for emacs-devel@gnu.org; Tue, 09 Apr 2019 12:32:25 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hDtfb-000rLS-4P for emacs-devel@gnu.org; Tue, 09 Apr 2019 18:32:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:QRyeMySz4SG9d2UnzR4VSHjaEuQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235170 Archived-At: > --- a/src/fns.c > +++ b/src/fns.c > @@ -5326,6 +5326,12 @@ syms_of_fns (void) > DEFSYM (Qcursor_in_echo_area, "cursor-in-echo-area"); > DEFSYM (Qwidget_type, "widget-type"); > > + DEFSYM (Qpure, "pure"); > + DEFSYM (Qside_effect_free, "side-effect-free"); > + DEFSYM (Qproper_list_p, "proper-list-p"); > + Fput (Qproper_list_p, Qpure, Qt); > + Fput (Qproper_list_p, Qside_effect_free, Qt); I think you can set the side-effect-free property to `error-free`, which is stronger. Other than that, it looks OK (tho I personally find doing it in C to be too painful, so I prefer moving this kind of code to subr.el). > I also attach a second patch which moves the proper-list-p tests to the > correct file following the function's rewriting in C. WDYT? LGTM, Stefan