unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* defconst risky-local (WAS: Question about defcustom and load-history)
       [not found]       ` <jwvv9ynim44.fsf-monnier+emacs@gnu.org>
@ 2019-05-06 22:57         ` Noam Postavsky
  2019-05-07  0:51           ` defconst risky-local Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Noam Postavsky @ 2019-05-06 22:57 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Emacs developers

On Mon, 6 May 2019 at 12:38, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> @@ -827,19 +839,12 @@ usage: (defconst SYMBOL INITVALUE [DOCSTRING])  */)

> -  Fset_default (sym, tem);
> -  Fput (sym, Qrisky_local_variable, Qt);
> +  Fset_default (sym, tem);      /* FIXME: set-default-toplevel-value? */
> +  Fput (sym, Qrisky_local_variable, Qt); /* FIXME: Why?  */

I would guess the risky-local-variable thing is because defconst
variables would generally not be expected to be changed, file-locally
or otherwise (though nothing stops it from happening).



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: defconst risky-local
  2019-05-06 22:57         ` defconst risky-local (WAS: Question about defcustom and load-history) Noam Postavsky
@ 2019-05-07  0:51           ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2019-05-07  0:51 UTC (permalink / raw)
  To: emacs-devel

>> @@ -827,19 +839,12 @@ usage: (defconst SYMBOL INITVALUE [DOCSTRING])  */)
>> -  Fset_default (sym, tem);
>> -  Fput (sym, Qrisky_local_variable, Qt);
>> +  Fset_default (sym, tem);      /* FIXME: set-default-toplevel-value? */
>> +  Fput (sym, Qrisky_local_variable, Qt); /* FIXME: Why?  */
> I would guess the risky-local-variable thing is because defconst
> variables would generally not be expected to be changed, file-locally
> or otherwise (though nothing stops it from happening).

Sounds like a good guess, but I wonder if someone can confirm that this
was indeed the reason.


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-07  0:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CABczVweJp1PaseSXD6QZseym4uvpijrnqb6D-q6vSTOPDMUgvA@mail.gmail.com>
     [not found] ` <87r2anzfbk.fsf@gnu.org>
     [not found]   ` <jwv8swvzddp.fsf-monnier+emacs@gnu.org>
     [not found]     ` <CABczVwdz4VjwYhP8_Q3g2X_6o_YBaQ82OuSg4L4pTmQG8GuAsA@mail.gmail.com>
     [not found]       ` <jwvv9ynim44.fsf-monnier+emacs@gnu.org>
2019-05-06 22:57         ` defconst risky-local (WAS: Question about defcustom and load-history) Noam Postavsky
2019-05-07  0:51           ` defconst risky-local Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).