unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: emacs-27 b46c75b: xref-matches-in-files: Big Tramp speed-up
Date: Wed, 08 Jan 2020 11:25:10 -0500	[thread overview]
Message-ID: <jwvlfqh7wbm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h816htg2.fsf@gmx.de> (Michael Albinus's message of "Wed, 08 Jan 2020 16:13:49 +0100")

>>>> But allow me to state for the record once more that I'm puzzled by the
>>>> architectural choice we're working with here.
>>> I know that.  Tramp follows the generic file name handler approach, as
>>> described in (info "(elisp) Magic File Names") .
>> Could someone explain to me why `file-local-name` has to be so much slower
>> than `tramp-file-local-name`?
> Internally, `file-local-name' uses `file-remote-p'. The latter goes
> through the file name handler machinery, and `tramp-file-name-handler'
> eats time, according to Dmitry's measures. Usually not a problem, but
> remarkable when you apply it to some ten thousand files as in
> `xref-matches-in-files'.

[ I think this should be in a comment in the code ;-)  ]
Hmm... I guess this deserves a bug number and we should try and figure
out why it's so much slower to go through the file-handler machinery
(and whether we can do something about it other than provide ad-hoc
coarse-grained operations).


        Stefan




  reply	other threads:[~2020-01-08 16:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200107133628.1996.14412@vcs0.savannah.gnu.org>
     [not found] ` <20200107133629.2E736211A5@vcs0.savannah.gnu.org>
     [not found]   ` <87y2uiiakq.fsf@gmx.de>
2020-01-08 13:52     ` emacs-27 b46c75b: xref-matches-in-files: Big Tramp speed-up Dmitry Gutov
2020-01-08 14:13       ` Michael Albinus
2020-01-08 14:56         ` Stefan Monnier
2020-01-08 15:13           ` Michael Albinus
2020-01-08 16:25             ` Stefan Monnier [this message]
2020-01-08 16:40               ` Michael Albinus
2020-01-08 18:56                 ` Stefan Monnier
2020-01-08 20:10                   ` Michael Albinus
2020-01-08 20:51                     ` Stefan Monnier
2020-01-08 23:42                       ` Dmitry Gutov
2020-01-13  9:50                         ` Philippe Vaucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlfqh7wbm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).