From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Really prevent quitting in sensitive contexts Date: Wed, 11 Mar 2020 22:20:00 -0400 Message-ID: References: <20200312020554.194607-1-dancol@dancol.org> Mime-Version: 1.0 Content-Type: text/x-markdown; coding=UTF-8 Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 12 03:21:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jCDTN-0007UR-W8 for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Mar 2020 03:21:21 +0100 Original-Received: from localhost ([::1]:60648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCDTM-00065Q-26 for ged-emacs-devel@m.gmane-mx.org; Wed, 11 Mar 2020 22:21:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40846) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCDSQ-0004kE-PR for emacs-devel@gnu.org; Wed, 11 Mar 2020 22:20:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCDSP-0006Xr-3q for emacs-devel@gnu.org; Wed, 11 Mar 2020 22:20:22 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1762) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCDSO-0006XR-Tw for emacs-devel@gnu.org; Wed, 11 Mar 2020 22:20:21 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5E5B482105; Wed, 11 Mar 2020 22:20:19 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 93F28820A9; Wed, 11 Mar 2020 22:20:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1583979610; bh=x/4dLQRxEdIaz/o7fKCDRpuBEVAmjk3Z4kiAFqq9OWY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a0yxTz0R65WJpRk69GUDulS9duUs9j/NO+GfMFQun8tThNtkyo2nGyt45OzUAVoyd zD9Tg2Qv0847vkVBhkigY89VzR5s1BKuZu9YBcbcJjei3IpZoWLpeW2ncJ6VbPpEwP p3fEy0Yr67zON3Sb0aHCMQYO3uVccyYJe8wTZTg7zblucOa11ScGWJmHwnvD/q2ScG VSf6gkaRv/+RDDJ/cWQ8dVfjkddEI512y98mjitJMNGfi9DMdPxiUqZgHQCn4j9LDR KeZmVRGpDqZ4p893els3sC28XX2pCnPq7G5wQJbYpB8xMtLIxdFOu1iQBDqCQSo5HU YN9W3DNNSJevQ== Original-Received: from pastel (unknown [216.154.50.221]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5B9311204C0; Wed, 11 Mar 2020 22:20:10 -0400 (EDT) In-Reply-To: <20200312020554.194607-1-dancol@dancol.org> (Daniel Colascione's message of "Wed, 11 Mar 2020 19:05:54 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245480 Archived-At: > with-local-quit is actually documented to allow this sort of > foreground quitting, AFAIK it's not just documented to allow that, but it's designed specifically for that. > but since the interactive C-g race is unavoidable, we should deprecate > use of with-local-quit for this purpose. I tend to agree. > This change adds a new inhibit-quit-override flag. Sounds like an arm's race: then we'll have to add a with-local-quit-override-override, etc... > +behaves as if 'inhibit-quit' were t. This change prevents > +with-local-quit from accidentally allowing quits inside process > +filters, redisplay callbacks, and other special contexts. I'm not really familiar with those accidental cases. Maybe they can be fixed more directly by not using with-local-quit? Are there bug#NNN where these are discussed? Stefan