From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Really prevent quitting in sensitive contexts
Date: Wed, 11 Mar 2020 22:20:00 -0400 [thread overview]
Message-ID: <jwvlfo6pbc7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200312020554.194607-1-dancol@dancol.org> (Daniel Colascione's message of "Wed, 11 Mar 2020 19:05:54 -0700")
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/x-markdown; coding=UTF-8, Size: 837 bytes --]
> with-local-quit is actually documented to allow this sort of
> foreground quitting,
AFAIK it's not just documented to allow that, but it's designed
specifically for that.
> but since the interactive C-g race is unavoidable, we should deprecate
> use of with-local-quit for this purpose.
I tend to agree.
> This change adds a new inhibit-quit-override flag.
Sounds like an arm's race: then we'll have to add
a with-local-quit-override-override, etc...
> +behaves as if 'inhibit-quit' were t. This change prevents
> +with-local-quit from accidentally allowing quits inside process
> +filters, redisplay callbacks, and other special contexts.
I'm not really familiar with those accidental cases.
Maybe they can be fixed more directly by not using with-local-quit?
Are there bug#NNN where these are discussed?
Stefan
next prev parent reply other threads:[~2020-03-12 2:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 2:05 [PATCH] Really prevent quitting in sensitive contexts Daniel Colascione
2020-03-12 2:20 ` Stefan Monnier [this message]
2020-03-12 2:32 ` Daniel Colascione
2020-03-12 10:07 ` Michael Albinus
2020-03-12 10:21 ` Robert Pluim
2020-03-12 10:33 ` Michael Albinus
2020-03-13 10:00 ` Michael Albinus
2020-04-14 6:56 ` Daniel Colascione
2020-04-14 8:40 ` Michael Albinus
2020-03-12 3:29 ` Óscar Fuentes
2020-03-12 7:21 ` Eli Zaretskii
2020-03-12 13:31 ` Richard Copley
2020-03-12 17:36 ` Drew Adams
2020-03-12 22:06 ` Stefan Monnier
2020-03-12 23:14 ` Richard Copley
2020-03-12 23:35 ` Stefan Monnier
2020-03-12 23:56 ` Richard Copley
2020-03-14 15:31 ` Drew Adams
2020-03-14 18:21 ` Stefan Monnier
2020-03-14 18:36 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlfo6pbc7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).