From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/org 46da64c 4/6: org-persist.el: Fix `add-hook' priority argument Date: Tue, 19 Oct 2021 10:16:38 -0400 Message-ID: References: <20211019125722.17993.60001@vcs0.savannah.gnu.org> <20211019125725.EA9CF209AA@vcs0.savannah.gnu.org> <875yttgm3h.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 19 16:40:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcqHi-00086p-IQ for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 16:40:10 +0200 Original-Received: from localhost ([::1]:53844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcqHh-0005Rk-9E for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Oct 2021 10:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpv3-0001nJ-4U for emacs-devel@gnu.org; Tue, 19 Oct 2021 10:16:48 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58811) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpv0-0002QA-1I for emacs-devel@gnu.org; Tue, 19 Oct 2021 10:16:44 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CA70B80499; Tue, 19 Oct 2021 10:16:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6428D8072A; Tue, 19 Oct 2021 10:16:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634652999; bh=6AN+Ok0j8m5BwEUxT/p4veXyH/8V2UuMp3QVSmDpJWs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WSYPvQ6/foD/31WAxljLtpyfEYI4SgABlT54kjywPj1ez4kex0Frv7VgtFcwgGNZv gtAO9w1qm16xgLlSl+CCl6/H7S8kPnlBBBmLCti4Uv9JVWMDLdT7zdNsMuhkSPdoEl hesgaxnoKTAEsG/n2xowh8bGe++SH1GHD1bNhYt/x3viymepZdLs0tQFRQ0EnYoxfb +nB/HnHDKEEbwfYJsot1vXo9cS0QKBdErFYYxmnuCpUifS8pe6E9Adlx21nf6t6tqX Ixwe6fOkOw5c96u2F16exvvn4gv2d2ljuKRdywz/CzwlDxJ1bZs1ZEOB09L7cXjcVR YxXoRl1BHeZTg== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1DE84120337; Tue, 19 Oct 2021 10:16:39 -0400 (EDT) In-Reply-To: <875yttgm3h.fsf@localhost> (Ihor Radchenko's message of "Tue, 19 Oct 2021 21:50:26 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277374 Archived-At: > The idea behind 100 is related to Org usage. We save buffer-local > `org-element--cache' to files. It needs to be done _after_ all the > possible changes in Org buffers are made. If any hook changes an Org > buffer after `org-persist-write-all', the saved value will become > invalid. I am not sure what can be a reasonable DEPTH value in such > case. Can it be something like 1? Looking through Emacs code base, I > can mostly see non-nil values as DEPTH argument. So, maybe 90? 91? The value should be chosen in accordance with other possibly interfering functions. IOW you need for the functions to agree on a numbering-convention. Since there is no such convention yet for your functions, you get to define it. So you can chose, for example 42 and from then on all function that need to come before `org-persist-write-all` simply have to refrain from using a value higher than 42. Stefan