From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Findirect_function Date: Fri, 14 Jan 2022 12:39:55 -0500 Message-ID: References: <87tue61tz1.fsf@elite.giraud> <87r19a9sbk.fsf@elite.giraud> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36144"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 18:41:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8Qa9-0009Gf-LS for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 18:41:45 +0100 Original-Received: from localhost ([::1]:48822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8Qa7-0000zH-SB for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 12:41:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8QYf-00089K-05 for emacs-devel@gnu.org; Fri, 14 Jan 2022 12:40:18 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8QYb-0003ws-TI for emacs-devel@gnu.org; Fri, 14 Jan 2022 12:40:11 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3623C440252; Fri, 14 Jan 2022 12:39:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BAD394423F2; Fri, 14 Jan 2022 12:39:56 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642181996; bh=9USWMcTXb4/rfq3mt4nWmNKWOvjhhYeQE4B2m8ziqhk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HSho9F//6mpnjjBtgRXR3XF1v3otkE7SJlVNFejD++i1Fd5oAiwN4hKyFbHITo9ar WzRwq/fUy+5Z0Dz1fyzQkEKA/Chj91RPO24b4HpT9Kl/cYq26d2Oqk0dgotwORSOLW awfji+2AaWvI2Wn8TMnxbjqu7Q15PWkIuZyHqiRWxoOoHwmAnsKzrWEQR1G80Zaum4 ZJwtR9Ch5nrJHsDyF0z7tEc030uDh2RDkekTg+uy2wQF3bEnkjc1n4jOg83Chy6VQi lRN0AtCchZ4XZt7c0cR34VaOOocI4/vPq/d52E4hIG+SCxrlDOkT5JlUYtpbugH92s W6QFFCUByhRwg== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9067D120234; Fri, 14 Jan 2022 12:39:56 -0500 (EST) In-Reply-To: <87r19a9sbk.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 14 Jan 2022 17:48:31 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284757 Archived-At: >> This should remove the corresponding comment. > You mean the /* Optimize=E2=80=A6 */ comment, right? Yes. >> And I think I'd only be willing to make such a change if it comes with >> some benchmarking showing that this optimization does not actually make >> a difference. > Do you happen to have some hints on how to do benchmarking in emacs? =F0= =9F=98=85 There's the `elisp-benchmarks` package on GNU ELPA, and another standard benchmark is to measure the time for Emacs to compile all its `.el` files. The `elisp-benchmarks` would welcome more benchmarks, so I'd encourage you to write some of your own and contribute them there ;-) Stefan