From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Fri, 04 Feb 2022 17:24:09 -0500 Message-ID: References: <6a5bb5a08b6337d733c5@heytings.org> <83leyq3kfk.fsf@gnu.org> <83a6f631k3.fsf@gnu.org> <838ruq2z5t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30538"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , gregory@heytings.org, mattiase@acm.org, larsi@gnus.org, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 04 23:26:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nG71v-0007hs-0G for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Feb 2022 23:26:11 +0100 Original-Received: from localhost ([::1]:34456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nG71t-0000KU-F5 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Feb 2022 17:26:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nG706-0007yV-SE for emacs-devel@gnu.org; Fri, 04 Feb 2022 17:24:18 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nG703-0006VQ-M8; Fri, 04 Feb 2022 17:24:18 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AA3CC1002DD; Fri, 4 Feb 2022 17:24:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F34361001D2; Fri, 4 Feb 2022 17:24:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644013450; bh=cFbv5z9UET5+Qf/27YDKoclOKNmaGHw7r61nb+BIG4k=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LzZ+1dhyfEn+Oe3K1rwOyxzuYouHGR4ruUdldzKQ0JGgNWjJr3/rjD2mJEvFasNM4 aUugb+9F2/LxgGLDhG/k5s9UK3LZzJfptRoIai9T1er1OE8yI/fCB6ZNY546/jkyqU IrfsYTZ04+k6vYKnSCWLhxRU+OjgzgWT9MiRHnkzNwGtCDWQQok9UIZuLONknDUfry L+lai8s25D3Vn83tQBjYz9Py8SQ1a0RA5bAL9pumjmp+XnlmLI76MzogleUNqdji47 EsILTnX9Xn5NXZ7sE1sFNeNopMrPK4z0tf4z1e6F5ru5XM8XdSaD/p4Qn6jhkD804J yA4apXKmpTUMw== Original-Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B999F1206C9; Fri, 4 Feb 2022 17:24:10 -0500 (EST) In-Reply-To: (Alan Mackenzie's message of "Fri, 4 Feb 2022 21:24:56 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285877 Archived-At: >> First, are symbols-with-pos supposed to happen in bytecode that >> doesn't deal with byte compilation? > > Symbols with pos are intended to be used only in compilation, native- as > well as byte-. They mustn't be output to .elc files. > >> If yes, why/when would such objects appear in GP bytecode? > > What does "GP" mean here, please? I think he meant "general purpose". So the answer is no, symbol-with-pos should not occur in general purpose code. And indeed that's why you have that boolean var controlling `eq` to choose between the slow version (used in the compiler) and the fast version (used everywhere else). The fast version is exactly the same as the previous `eq` but it still makes the new `eq` slower because of the extra choice between the slow version and the fast one. >> The pseudovector part is not needed if we just extend Lisp_Symbol to >> have an additional field 'position'. > > Yes. I'm not sure we can do this, though. I can't see why we couldn't but I can't see why it would help either. We'd still have the problem that two different objects may need to be considered `eq`, so we need `eq` to be slower. Stefan