From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate Date: Sun, 15 May 2022 16:16:53 -0400 Message-ID: References: <165264034407.21518.7194358780844409479@vcs2.savannah.gnu.org> <20220515184546.6304CC01683@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15104"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Augusto Stoffel To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 15 22:18:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqKgk-0003g5-II for ged-emacs-devel@m.gmane-mx.org; Sun, 15 May 2022 22:18:02 +0200 Original-Received: from localhost ([::1]:50514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqKgj-0006Vk-0g for ged-emacs-devel@m.gmane-mx.org; Sun, 15 May 2022 16:18:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqKfm-0005og-4o for emacs-devel@gnu.org; Sun, 15 May 2022 16:17:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqKfj-0004Ml-HU for emacs-devel@gnu.org; Sun, 15 May 2022 16:17:00 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 59DD5100163; Sun, 15 May 2022 16:16:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1C91810000A; Sun, 15 May 2022 16:16:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1652645816; bh=5vSBrVbSBa5bQkVP4qQYwjQInwxuvGUD59Iq70oj0D0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IzN7TYdUBr73nMxrO3vUL4ZWRWdmCwGYoHnNmHMjheIFmiiaphnfNwNMZhydVf6dG Efl7qnUgpPs3RW8O/zttEnudE4fQ/cvdgP06wclPj/EIxsj1eyX2pqAA9tEEK2W51t tC//6lu+LW7me8bTJQdDpWURNqtBhiN2mMBl6TgwGtlkjzU0fpYs6ibpnnDmcTSEyI IcxqL3xoJa8t/Dt1SpsP156VHV7UNA5+7R9/+6dowBriAGgknuy5LrghxXZT3Be+qL HmkBMaN/GaYpk5Xgvlxulapo5Mx/RGuSbJJ+fHs0cFYvOLqGrr2iUO/WhyOfUpkOMq ZgxtfIjzJBsCw== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DED7D1201C9; Sun, 15 May 2022 16:16:55 -0400 (EDT) In-Reply-To: <20220515184546.6304CC01683@vcs2.savannah.gnu.org> (Juri Linkov's message of "Sun, 15 May 2022 14:45:45 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289798 Archived-At: > (when filter > + (make-local-variable 'isearch-filter-predicate) > (add-function :after-while isearch-filter-predicate filter)) `add-function` is modeled after `add-hook`, so the above `make-local-variable` would be better replaced with (add-function :after-while (local 'isearch-filter-predicate) filter) [ Of course, that's pure theory. You'd better test it first. ] Stefan