unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Augusto Stoffel <arstoffel@gmail.com>
Subject: Re: master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate
Date: Sun, 15 May 2022 16:16:53 -0400	[thread overview]
Message-ID: <jwvlev2d02z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220515184546.6304CC01683@vcs2.savannah.gnu.org> (Juri Linkov's message of "Sun, 15 May 2022 14:45:45 -0400 (EDT)")

>          (when filter
> +          (make-local-variable 'isearch-filter-predicate)
>            (add-function :after-while isearch-filter-predicate filter))

`add-function` is modeled after `add-hook`, so the above
`make-local-variable` would be better replaced with

    (add-function :after-while (local 'isearch-filter-predicate) filter)

[ Of course, that's pure theory.  You'd better test it first.  ]


        Stefan




       reply	other threads:[~2022-05-15 20:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165264034407.21518.7194358780844409479@vcs2.savannah.gnu.org>
     [not found] ` <20220515184546.6304CC01683@vcs2.savannah.gnu.org>
2022-05-15 20:16   ` Stefan Monnier [this message]
2022-05-15 21:10     ` master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate Augusto Stoffel
2022-05-18 18:59       ` Juri Linkov
2022-05-18 20:51         ` Stefan Monnier
2022-05-19 16:20           ` Juri Linkov
2022-05-22 14:40             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlev2d02z.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=arstoffel@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).