From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate Date: Sun, 22 May 2022 10:40:12 -0400 Message-ID: References: <165264034407.21518.7194358780844409479@vcs2.savannah.gnu.org> <20220515184546.6304CC01683@vcs2.savannah.gnu.org> <87lev2h590.fsf@gmail.com> <86ee0qd5sf.fsf@mail.linkov.net> <86czg9trgp.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28719"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Augusto Stoffel , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 22 16:41:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsmlq-0007Jd-74 for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 16:41:26 +0200 Original-Received: from localhost ([::1]:59956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsmll-0007S3-Dr for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 10:41:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsmkt-0006fd-I8 for emacs-devel@gnu.org; Sun, 22 May 2022 10:40:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsmko-000731-QL for emacs-devel@gnu.org; Sun, 22 May 2022 10:40:26 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B8E4644223F; Sun, 22 May 2022 10:40:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A1EAF442234; Sun, 22 May 2022 10:40:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1653230417; bh=70rOIbaIg6FuyzVWG9FBxdnnotTJHnpjYPuaKncKeow=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HjnB8x5A1zIj58OHw9ffnLGUHzWx1RgzvIEZ5YaEgigSYj+RPZf2HkbZN64fi4L+Z Q9ms/XSq7Lk4U7vPXbPrxz4wHfzbyQkMnO9z4bQer5F3I5BH6BFV31me1yaZlrJ3JI rNo3Awuu5BKGpQFcz+VqZbEmLDB5i3FmthLvBPyjmAyeldWm39e60T4XRqcrNgVhKn ZlsEl7wH3Inwj90pdsyrNFF8w7X6GZDqRhnZFQVSwGZ0i4gn4Mfm5aOkUXIVcdN7Ov Qq6TVLkwkDEA9gkZDsbKQH5B3ECmpoI89ArRdTSgTfl+ZJhIV6rAoITa9J8VPowshs Z1mDk0O4qBmNg== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4890A1208FA; Sun, 22 May 2022 10:40:17 -0400 (EDT) In-Reply-To: <86czg9trgp.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 19 May 2022 19:20:46 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290096 Archived-At: >> How 'bout the patch below? > Alas, it even breaks exiting the minibuffer directly from the minibuffer. >> - record_unwind_protect_void (run_exit_minibuf_hook); >> + record_unwind_protect (run_exit_minibuf_hook, Fcurrent_buffer ()); > After a little debugging I see that everything is fixed after replacing > 'Fcurrent_buffer ()' with 'minibuffer': > record_unwind_protect (run_exit_minibuf_hook, minibuffer); Duh, indeed, I misread the code, thanks for doing my debugging for me. Pushed to `master`. Stefan