From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Wed, 19 Oct 2022 08:19:32 -0400 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> <87mt9s47f1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 19 14:21:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol84L-00083v-0g for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 14:21:09 +0200 Original-Received: from localhost ([::1]:37666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol84J-0003kh-9Q for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 08:21:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol82s-0002ts-VI for emacs-devel@gnu.org; Wed, 19 Oct 2022 08:19:39 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol82r-0004GN-Aj for emacs-devel@gnu.org; Wed, 19 Oct 2022 08:19:38 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8666F80091; Wed, 19 Oct 2022 08:19:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C62A680CB6; Wed, 19 Oct 2022 08:19:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666181973; bh=jmxWeUPDBNCBfolooNmM176ApVwLAaCxQPaAAWL59DQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JIL4SOqeYbXvNOLzjfBiighovfzeKu7fcbtHdf3HxdoBDnelSH808ML5RtTdz9Olz RcijmJs5YnjBHD19nDofyt6dQhP2lZtRgbft1+w1jU9IcU4Kg/MIDOLV0eppqBpV6w xMSN7nwlqF1efkpOaRjsHXeKa1VZzgdMS9GFLMk7A7GZD53QMY0G4xGxScc83rX1GV sWC1GnTT/2Zaa9dXdqPvArV8ptKuSBrXsW6I1AM/6PKPT1mEHIGaegPMpUin7FnNxw UP5mAOPRU23aaZxIBgeav0jwM3cQOaZKrBoKZOY4RiBj9xGO5r8XQYVbem3G10W0fs ufzmdjJcx+o0w== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 93D96120F35; Wed, 19 Oct 2022 08:19:33 -0400 (EDT) In-Reply-To: <87mt9s47f1.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 19 Oct 2022 07:08:34 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298113 Archived-At: Philip Kaludercic [2022-10-19 07:08:34] wrote: > Stefan Monnier writes: >>> I have pushed a first draft and it appears to work. It doesn't yet >>> handle all attribute (such as :doc), but that should be doable when I >>> find the time. >> Side note: installing packages from Git (like what you're implementing >> in the `package+vc` branch) is already one of the functionalities >> supported by `elpa-admin.el` so it would be good to try and share/reuse >> that code as much as possible. > That is only possible insofar I don't have to rely on Git features, > since package-vc intends to be VC-generic. I'm thinking of things like the code that handles `:doc` or `:make`. These don't care about Git. I don't think that the code in `elpa-admin.el` can be used as-is, but it would be good to try and change them in tandem (maybe by extracting the common code into some new file?). >> Actually part of `elpa-admin.el` might also be helpful for the >> ELPA-bundling feature. >> So we should move more of `elpa-admin.el` into Emacs's own code. > As part of `package-vc' or as a new module? I think either way is fine. The whole `elpa-admin.el` contains things that are irrelevant to Emacs itself, so we'll likely keep a separate file like that, but the code that's useful for other uses (i.e. package-vc and/or bundled-ELPA) should be moved out (tho elpa-admin.el has to be backward compatible to some extent, so we'll have to keep a "local" copy of whatever is moved to a common file hosted in emacs.git, at least for a few years). Stefan