From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Remove js--treesit-backward-up-list or fix it Date: Sat, 29 Oct 2022 15:20:03 -0400 Message-ID: References: <8B978AF7-B1CA-4C8A-9E89-84D0DEC7884C@gmail.com> <87h6znxkr0.fsf@thornhill.no> <0849BE6B-B5B4-47E0-B4EA-F93F6947C2B7@gmail.com> <87h6zmscqj.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Yuan Fu , Theodor Thornhill To: Theodor Thornhill via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 21:21:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oorOA-0006Kp-9P for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 21:21:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oorNW-00046E-4F; Sat, 29 Oct 2022 15:20:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oorNO-00045w-V0 for emacs-devel@gnu.org; Sat, 29 Oct 2022 15:20:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oorNL-0001uf-Dl for emacs-devel@gnu.org; Sat, 29 Oct 2022 15:20:14 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E45EA100134; Sat, 29 Oct 2022 15:20:05 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6920C10000D; Sat, 29 Oct 2022 15:20:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667071204; bh=VjkuqNPE7fq1EKXIXwoSnqkY6VWT0QUQfrER1t2GKeA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ntqKtgtwMZn+KM73/EcXAkLlLSVxnflojS8L922LK5Ryw4J0cG3PCgGYzcbmcCq2V BGcIZYNruZ6MtiNzkIerq6d/FXH12LlcsQZlzjahfs/5u7T2xgAOtkZSoEGkU4h4oM jHlHxAswK96YSwRXEUsstyayJs3dsN0UZkOB2rlAHNQhUgDLBoq4Vgjaj6HAst8tvD 7LpTXOFo7VUt/BQrvBXnqN4EshdjM8Vrg2Q2G4F3Hr0Mn5/0pJfzh4euWsxIFsXU4J JHF0T8vRUNCDAg75sIuE7Lf/Ih6E4oEVZWHS6fgJMpVvEApqr61Qx9JVauXUYPQd5z 3tNJBSwnl6d6A== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 448A61207DD; Sat, 29 Oct 2022 15:20:04 -0400 (EDT) In-Reply-To: <87h6zmscqj.fsf@thornhill.no> (Theodor Thornhill via's message of "Sat, 29 Oct 2022 20:31:32 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298777 Archived-At: > Because of all the stuff we set before we init tree sitter we get a > super unwanted behavior of the cursor jumping back to indentation for > every () {} etc. This is because of these settings, which are IMO pretty > bad defaults: > ``` > (setq-local electric-indent-chars > (append "{}():;," electric-indent-chars)) ;FIXME: js2-mode adds "[]*". > (setq-local electric-layout-rules > '((?\; . after) (?\{ . after) (?\} . before))) > ``` While these may be bad defaults, they should provide reasonable behavior, so if you get cursor jumping with such settings, then we should fix that regardless if its the default. Stefan