From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bbe35c280c: Prevent stale servers when using eglot-extend-to-xref Date: Thu, 22 Dec 2022 10:40:36 -0500 Message-ID: References: <167170857225.23253.4229481345211602184@vcs2.savannah.gnu.org> <20221222112935.58A32C05F44@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 22 16:41:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p8NhP-0000Zp-KY for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Dec 2022 16:41:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8Ngf-0003aX-SL; Thu, 22 Dec 2022 10:40:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8Nga-0003aD-9Q for emacs-devel@gnu.org; Thu, 22 Dec 2022 10:40:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8NgY-0002yq-Pg for emacs-devel@gnu.org; Thu, 22 Dec 2022 10:40:44 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E4D86805BE; Thu, 22 Dec 2022 10:40:39 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5BED280181; Thu, 22 Dec 2022 10:40:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671723638; bh=80XylVbGTrlgaaxW+z/U4R2WLw+i1A60Ch4URPuo8nI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A1zvvnDFDQlFoFzFQwyrk4WpyXWxT0GwNOmUGs2bQJ4daN21D/1s86mRPrkg8XDHf Ovt1vvxPf3bb7kQrmjoq7DI1ja5oCgJk7QZ3ysO5oke0yeKyEUuz0YzqFjkCqBbp8D A4U4iZWrk47ihsLFldaL/YOg360hsYRDpDds8jvwO+I//vuJWb2WzxYnBZwLuepgK0 7GtfqiO7mb37VySORyJAZ9PepeWzy31iDjeDdsC4VSkeTFWADNmdcKh2+UV9OO9A09 +lQF7vvUKnch+Ki60iv42F/HP9Q7G13qth9/REJY+4UurLSzrto0+8eVEj1gz8ZAg8 QWL9aUQ/GC3zw== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 25762123052; Thu, 22 Dec 2022 10:40:38 -0500 (EST) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Thu, 22 Dec 2022 15:30:15 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301793 Archived-At: >> Do we still need it to be weak? > Prolly not, if we presume the operations running up to the new cleanup > can't throw. Probably a fair assumption. But better be safe? The usual tension between trying to silently push the unexpected corner case under the rug vs trying to avoid those corner cases staying unnoticed. > Does value-weakness in a typically small hash table hurt GC > significantly somehow? I'd doubt it. They do come at a cost, of course, but so does everything. Stefan