unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 bbe35c280c: Prevent stale servers when using eglot-extend-to-xref
Date: Thu, 22 Dec 2022 10:40:36 -0500	[thread overview]
Message-ID: <jwvlemzlabr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALDnm506FR3q77Dgkad8EUZ+PMHVDT_czy72+u6KGLP0BQkdmQ@mail.gmail.com> ("João Távora"'s message of "Thu, 22 Dec 2022 15:30:15 +0000")

>> Do we still need it to be weak?
> Prolly not, if we presume the operations running up to the new cleanup
> can't throw.  Probably a fair assumption.  But better be safe?

The usual tension between trying to silently push the unexpected corner
case under the rug vs trying to avoid those corner cases
staying unnoticed.

> Does value-weakness in a typically small hash table hurt GC
> significantly somehow?

I'd doubt it.  They do come at a cost, of course, but so
does everything.


        Stefan




  reply	other threads:[~2022-12-22 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167170857225.23253.4229481345211602184@vcs2.savannah.gnu.org>
     [not found] ` <20221222112935.58A32C05F44@vcs2.savannah.gnu.org>
2022-12-22 15:08   ` emacs-29 bbe35c280c: Prevent stale servers when using eglot-extend-to-xref Stefan Monnier
2022-12-22 15:30     ` João Távora
2022-12-22 15:40       ` Stefan Monnier [this message]
2022-12-22 15:43         ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlemzlabr.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).