From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded. Date: Sat, 09 Dec 2023 18:26:22 -0500 Message-ID: References: <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org> <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org> <020ab182-0e3d-4e8d-9415-c93863b95638@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40332"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Eli Zaretskii To: Jens Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 10 00:27:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rC6jP-000AFm-6A for ged-emacs-devel@m.gmane-mx.org; Sun, 10 Dec 2023 00:27:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rC6iY-0007rR-Jc; Sat, 09 Dec 2023 18:26:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC6iW-0007qx-On for emacs-devel@gnu.org; Sat, 09 Dec 2023 18:26:40 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC6iH-0007Hl-ID; Sat, 09 Dec 2023 18:26:40 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4A23210019F; Sat, 9 Dec 2023 18:26:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702164383; bh=NWP5t2KGScbyRd5PfYiagiEvVS6oE9NKGTFlmNqHhdc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nKi/kf368O35OXM4EGR1tZ7oTdRTPZQ66GBWNBb70XtuEy06uHEoGEJoyrsAhSvQ4 UH96cuCWBSwCIj7P4vgy7bl/K51whO3CDFr3EH1XCaIeB4tDfrqWXrbEKfakGuIBGH uV3xy4daBHZM7BpWpbGVDkYRK4Sy8HayzLX55KmyGirsaWdPiL+YcmmT0xNa6j6vzV Ns9faTnQjq9RrLnYE34AN1z7Mo3poaQuUnfaVoq8G42D9ZPJpTACeM7HekJ8XdDkQQ qGF2uMzn2KvggKNTJwg8BE7Op4Y3nbeUh9DtCUWmIzOrvnrH2VT/MgTr+O+mV72jhP dzWwgBabyZ9WQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 71A4E100189; Sat, 9 Dec 2023 18:26:23 -0500 (EST) Original-Received: from pastel (unknown [45.72.207.126]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 486F412043F; Sat, 9 Dec 2023 18:26:23 -0500 (EST) In-Reply-To: (Jens Schmidt's message of "Thu, 7 Dec 2023 23:25:44 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313647 Archived-At: > is hard to digest at 11PM, so a comment won't hurt here, I guess. Plus > it seems to violate the order promise done in the docstring of the > function ("... sorted in the `string<' order"). Interestingly, this is not directly caused by my patch, it just triggers an existing bug in the code. E.g.: ELISP> (file-expand-wildcards "/u*/*m*") ("/usr/games" "/u/dummy" "/u/emma" "/u/monnier" "/u/omnibook-disk") ELISP> (sort (file-expand-wildcards "/u*/*m*") #'string<) ("/u/dummy" "/u/emma" "/u/monnier" "/u/omnibook-disk" "/usr/games") AFAICT this can be fixed with the patch below. Stefan diff --git a/lisp/files.el b/lisp/files.el index 1cdcec23b11..a71292ab025 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -7544,7 +7567,7 @@ file-expand-wildcards (directory-file-name dirpart) nil regexp)) (list dirpart))) contents) - (dolist (dir dirs) + (dolist (dir (nreverse dirs)) (when (or (null dir) ; Possible if DIRPART is not wild. (file-accessible-directory-p dir)) (let ((this-dir-contents