From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded.
Date: Sat, 09 Dec 2023 18:26:22 -0500 [thread overview]
Message-ID: <jwvlea3klkk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <c88949a7-8728-4688-afa0-7a52bce61b85@vodafonemail.de> (Jens Schmidt's message of "Thu, 7 Dec 2023 23:25:44 +0100")
> is hard to digest at 11PM, so a comment won't hurt here, I guess. Plus
> it seems to violate the order promise done in the docstring of the
> function ("... sorted in the `string<' order").
Interestingly, this is not directly caused by my patch, it just triggers
an existing bug in the code. E.g.:
ELISP> (file-expand-wildcards "/u*/*m*")
("/usr/games" "/u/dummy" "/u/emma" "/u/monnier" "/u/omnibook-disk")
ELISP> (sort (file-expand-wildcards "/u*/*m*") #'string<)
("/u/dummy" "/u/emma" "/u/monnier" "/u/omnibook-disk" "/usr/games")
AFAICT this can be fixed with the patch below.
Stefan
diff --git a/lisp/files.el b/lisp/files.el
index 1cdcec23b11..a71292ab025 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -7544,7 +7567,7 @@ file-expand-wildcards
(directory-file-name dirpart) nil regexp))
(list dirpart)))
contents)
- (dolist (dir dirs)
+ (dolist (dir (nreverse dirs))
(when (or (null dir) ; Possible if DIRPART is not wild.
(file-accessible-directory-p dir))
(let ((this-dir-contents
next prev parent reply other threads:[~2023-12-09 23:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org>
[not found] ` <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org>
2023-12-05 23:20 ` master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded Stefan Monnier
2023-12-06 1:18 ` Po Lu
2023-12-06 12:14 ` Eli Zaretskii
2023-12-06 16:12 ` Stefan Monnier
2023-12-06 17:07 ` Eli Zaretskii
2023-12-06 21:32 ` Stefan Monnier
2023-12-07 6:19 ` Eli Zaretskii
2023-12-06 20:50 ` Jens Schmidt
2023-12-07 20:06 ` Stefan Monnier
2023-12-07 22:25 ` Jens Schmidt
2023-12-09 20:09 ` Stefan Monnier
2023-12-09 23:26 ` Stefan Monnier [this message]
2023-12-10 5:10 ` Stefan Monnier
2023-12-12 21:22 ` Jens Schmidt
2023-12-21 14:40 ` Stefan Monnier
2023-12-07 2:49 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlea3klkk.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).