From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning Date: Tue, 12 Dec 2023 18:13:06 -0500 Message-ID: References: <170197287539.12661.7539324399514249195@vcs2.savannah.gnu.org> <20231207181435.BCB79C0C6AD@vcs2.savannah.gnu.org> <73d5b60d-afbd-4543-8001-9fe043b4b6ab@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13605"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Jens Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 13 00:14:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDBxN-0003Kn-Ur for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Dec 2023 00:14:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDBwc-0003HD-6C; Tue, 12 Dec 2023 18:13:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDBwZ-0003Gw-8k for emacs-devel@gnu.org; Tue, 12 Dec 2023 18:13:39 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDBwX-0001ka-PS for emacs-devel@gnu.org; Tue, 12 Dec 2023 18:13:39 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 296B08076C; Tue, 12 Dec 2023 18:13:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702422815; bh=dQCbusz3THLBbfiOo/0uHd//y57mT+XaiEZ89FfmYnk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Bx7vxuf5F6wovcvs8U4vBqxj9wI4fN3Th3m+Au3NzOowrTRapupG0w1zufDtbQ02A AUeN/FdltV88r/cEhOcW8JNQWQkdARG5xbRnmQxroxCdV4sL6/qCHJfYayvlvI7KdE bggre464Jh6MKWSKvQllE1mGtxW1TMP1gaGg7dbQu/QUKpkl6J/KzugXC22vdWc0V3 iUhqrjArSp/jKyr4UmZemhlRs9cIrRD6fPPSnrogmeGDujjduW/M31JFmqXjQixB4Q rJVZtpP5XzjtkIvmm+tLgz3q2z8gH1ZFPkBxDFl+Qzo+pi5Hk/QvNARRwPfQjzNLt8 Uk0ktii8VQ0DA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 10EBF80357; Tue, 12 Dec 2023 18:13:35 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 00C051202E0; Tue, 12 Dec 2023 18:13:34 -0500 (EST) In-Reply-To: <73d5b60d-afbd-4543-8001-9fe043b4b6ab@vodafonemail.de> (Jens Schmidt's message of "Tue, 12 Dec 2023 22:48:56 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313735 Archived-At: > But when I tried to place that advice-checking-code into loadup.el, > I also saw this rmc.el and didn't quite know what to do with it. I > thought that Lars might have placed it *inadvertently* after the > > (load "site-load" t) > > block, because, um, logically it belongs to before that, doesn't it? That was also my impression, indeed. > So probably TRT here would be to place these paragraphs as follows: > > 0. (load "leim/leim-list.el" t) > > 1. (load "emacs-lisp/rmc") > > 2. Check for advices (on core libs only). > > 3. (load "site-load" t) > > 4. "default-directory must be unibyte" > > What do you think? I decided that it was OK to keep "check for advice" after loading `site-load` now that it's a warning. IOW I don't have a strong opinion on the order between `2` and `3`. But I agree that `rmc` should come before those two. Stefan