From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: pcase generates an unprintable expansion for a form in test erc--restore-initialize-priors Date: Mon, 03 Jun 2024 13:42:39 -0400 Message-ID: References: <87sey3awa5.fsf@web.de> <87mso84ogy.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27659"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen via "Emacs development discussions." To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 03 19:43:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEBiV-0006wv-8E for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Jun 2024 19:43:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEBht-0001Cj-DQ; Mon, 03 Jun 2024 13:42:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEBhq-0001CC-Of for emacs-devel@gnu.org; Mon, 03 Jun 2024 13:42:51 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEBhj-0004Gr-As for emacs-devel@gnu.org; Mon, 03 Jun 2024 13:42:50 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 918FB100035; Mon, 3 Jun 2024 13:42:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1717436560; bh=GtQ0KeBmmgdvlW3bMTQCZDWZCXRpO65/d7Vkebl9aEc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e5vtOq9v0rub3CG9Gu+N3m8+1HQo9a3XTA5ik6T2M8OBh1MURViUnjhLuRdO1MvJZ 2qyHPT9Ng20g2bnw8GYf2tX5xr0TX/0Vu7+PU18Jf40Y8uWyfrZ6mpfhl5dAVszHC4 mzFLUyRgKo92lUTWUX3qDmVIr5vXVgig4rzsaeRmLg9tK11t/TpTJ458el9PwMTj4p EGZEtNXBCrGFHs1yi4rFx/sTAzc3SkJObAJyMmzwY1SkOZxUCdGiTB+SA9DHdcE6PL Z8l91NdcLyqp3jZXwDWVYDCLfm6Huiq/9hEJ6dxxq3SEc8pvRzSX/W3NRnEjuYAuWL v0adclS4r17IQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9F6BD100048; Mon, 3 Jun 2024 13:42:40 -0400 (EDT) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 85702120588; Mon, 3 Jun 2024 13:42:40 -0400 (EDT) In-Reply-To: <87mso84ogy.fsf@web.de> (Michael Heerdegen's message of "Wed, 29 May 2024 17:39:09 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319800 Archived-At: > Anyway, apart from this little detail the patch is an obvious > improvement, so please go ahead. Well, there were some interactions with other pcase optimizations which made it sometimes generate worse code. I think I got this mostly fixed now (not completely, but that's the world of compiler optimization for you), so I just pushed it to `master`. Stefan